You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by majetideepak <gi...@git.apache.org> on 2018/05/30 21:49:49 UTC
[GitHub] orc pull request #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SAS...
GitHub user majetideepak opened a pull request:
https://github.com/apache/orc/pull/275
ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is not found
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/majetideepak/orc ORC-371
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/275.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #275
----
commit 65c537767474708a91cf5a15cae45acf4fcea552
Author: Deepak Majeti <de...@...>
Date: 2018-05-30T21:46:08Z
ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is not found
----
---
[GitHub] orc issue #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is no...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/275
Thanks for this bug. I will push a patch to fix this.
---
[GitHub] orc pull request #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SAS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/275
---
[GitHub] orc issue #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is no...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/275
Since there is some investigation needed here, I am going to merge this patch. We can enable `NO_SASL` build in a later patch. Right now, this is causing a build failure by default.
---
[GitHub] orc issue #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is no...
Posted by jamesclampffer <gi...@git.apache.org>.
Github user jamesclampffer commented on the issue:
https://github.com/apache/orc/pull/275
Rather than skipping the entire libhdfs++ build you could set the NO_SASL parameter if openssl or cyrus is missing to build libhdfs++ without support for strong authentication.
At one point someone added a partial implementation of SASL DIGEGT-MD5 directly in libhdfs++ and I think that may try to use SSL's RNG to generate nonces (and looks like NO_SASL might not prevent that). If that breaks the build with NO_SASL set we can get rid of that code in libhdfs++. Even if that implementation worked it'd prevent the library from being FIPS 140-2 compliant which is a deal breaker for my work.
---
[GitHub] orc issue #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is no...
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/275
CC @jamesclampffer
---
[GitHub] orc issue #275: ORC-371: [C++] Disable Libhdfspp build when Cyrus SASL is no...
Posted by jamesclampffer <gi...@git.apache.org>.
Github user jamesclampffer commented on the issue:
https://github.com/apache/orc/pull/275
@majetideepak it looks like the build still fails with this in place. OrcHdfsFile.cc includes hdfspp.h which won't exist if libhdfs++ isn't extracted.
```
<cut>/apache_orc/build$ cmake .. -DBUILD_JAVA=OFF
-- No build type selected, default to ReleaseWithDebugInfo
-- compiler GNU version 4.9.4
-- Could NOT find CYRUS_SASL (missing: CYRUS_SASL_SHARED_LIB CYRUS_SASL_INCLUDE_DIR)
-- WARNING: Libhdfs++ library was not built because the required CyrusSASL library was not found
-- Configuring done
-- Generating done
-- Build files have been written to: <cut>/apache_orc/build
<cut>:~/apache_orc/build$ make package
[ 7%] Built target googletest_ep
[ 14%] Built target snappy_ep
[ 21%] Built target zlib_ep
[ 28%] Built target lz4_ep
[ 35%] Built target protobuf_ep
[ 36%] Building CXX object c++/src/CMakeFiles/orc.dir/OrcHdfsFile.cc.o
<cut>/apache_orc/c++/src/OrcHdfsFile.cc:32:27: fatal error: hdfspp/hdfspp.h: No such file or directory
#include "hdfspp/hdfspp.h"
^
compilation terminated.
c++/src/CMakeFiles/orc.dir/build.make:693: recipe for target 'c++/src/CMakeFiles/orc.dir/OrcHdfsFile.cc.o' failed
```
---