You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "difin (via GitHub)" <gi...@apache.org> on 2025/04/09 20:10:25 UTC
[PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
difin opened a new pull request, #5759:
URL: https://github.com/apache/hive/pull/5759
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
To upgrade parquet version in Hive to 1.15.1
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To use the latest parquet version.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### Is the change a dependency upgrade?
<!--
If yes, please attach a file with output from mvn dependency:tree to validate a complete upgrade of dependency.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Existing pre-commit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
Posted by "difin (via GitHub)" <gi...@apache.org>.
difin commented on code in PR #5759:
URL: https://github.com/apache/hive/pull/5759#discussion_r2036230355
##########
ql/pom.xml:
##########
@@ -1141,6 +1141,12 @@
<exclude>META-INF/versions/*/module-info.class</exclude>
</excludes>
</filter>
+ <filter>
Review Comment:
Yes, I'm not sure about that, was also asking myself the same question..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
Posted by "difin (via GitHub)" <gi...@apache.org>.
difin commented on PR #5759:
URL: https://github.com/apache/hive/pull/5759#issuecomment-2792459202
reopening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5759:
URL: https://github.com/apache/hive/pull/5759#discussion_r2036112025
##########
ql/pom.xml:
##########
@@ -1141,6 +1141,12 @@
<exclude>META-INF/versions/*/module-info.class</exclude>
</excludes>
</filter>
+ <filter>
Review Comment:
Apparently this fixes the compile-time problem I faced here:
https://issues.apache.org/jira/browse/HIVE-28882?focusedCommentId=17941008&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17941008
looks good for the first sight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
Posted by "difin (via GitHub)" <gi...@apache.org>.
difin commented on PR #5759:
URL: https://github.com/apache/hive/pull/5759#issuecomment-2792458379
The PR is stuck in status "processing changes" for over 12 hours, trying to close and reopen...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
Posted by "abstractdog (via GitHub)" <gi...@apache.org>.
abstractdog commented on code in PR #5759:
URL: https://github.com/apache/hive/pull/5759#discussion_r2036114275
##########
ql/pom.xml:
##########
@@ -1141,6 +1141,12 @@
<exclude>META-INF/versions/*/module-info.class</exclude>
</excludes>
</filter>
+ <filter>
Review Comment:
can you tell me how the same classes don't cause any problem while compiling hive with Java8? I can see versions/21, versions/17, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #5759:
URL: https://github.com/apache/hive/pull/5759#issuecomment-2791640613
Upgrading maven shade plugin to **3.6.0** is resulting in successful build without any need for exclusion. I checked in parquet-java project also by printing effective pom (`mvn help:effective-pom`) and found that the maven shading plugin version is 3.6.0
The simple explanation can be that maven shade plugin currenty used in hive i.e. 3.5.0 is released in 2023 and java 22 came in 2024 (based on google search) :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28895: Upgrade parquet version to 1.15.1 [hive]
Posted by "difin (via GitHub)" <gi...@apache.org>.
difin closed pull request #5759: HIVE-28895: Upgrade parquet version to 1.15.1
URL: https://github.com/apache/hive/pull/5759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org