[GitHub] [helix] kaisun2000 commented on pull request #1328: Implement TestBestPossibleExternalViewVerifier

[GitBox <gi...@apache.org>]

kaisun2000 commented on pull request #1328:
URL: https://github.com/apache/helix/pull/1328#issuecomment-689896086


   > Many tests (especially WAGED tests) are using StrictMatchExternalViewVerifier. We need to do the same for that too.
   > 
   > Overall, my suggestion is still to add waiting to the specific test case where need it. This generic cooling down logic does not look reasonable to me. The cooldown shall be with the test logic.
   > 
   > One alternative way is that we add a parameter to the verify method that you can specify a cooldown in the caller logic. Could you please consider this solution?
   
   I did a search of places using `verifyByPolling()`. There are between 150 to 200 places. 
   
   So shall we have another one called as the following?
   
   ```
   public boolean verifyByPolling(long timeout, long period, long cooldown) {
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org