You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "covidium (via GitHub)" <gi...@apache.org> on 2024/08/28 11:02:20 UTC

[PR] Update hook-weight to -1 for proper ArgoCD sync [airflow]

covidium opened a new pull request, #41827:
URL: https://github.com/apache/airflow/pull/41827

   According to ArgoCD, the pre-install hook-weight should be -1 in order to execute the hook before running the upgrade.
   https://argo-cd.readthedocs.io/en/stable/user-guide/helm/#hook-tips


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update hook-weight to -1 for proper ArgoCD sync [airflow]

Posted by "tailorck (via GitHub)" <gi...@apache.org>.
tailorck commented on PR #41827:
URL: https://github.com/apache/airflow/pull/41827#issuecomment-2355838492

   @hussein-awala , are the values that @covidium proposed more appropriate? This PR is blocking some important company initiative on our end and we would like to find a resolution quickly. We appreciate your cooperation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update hook-weight to -1 for proper ArgoCD sync [airflow]

Posted by "covidium (via GitHub)" <gi...@apache.org>.
covidium closed pull request #41827: Update hook-weight to -1 for proper ArgoCD sync
URL: https://github.com/apache/airflow/pull/41827


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update hook-weight to -1 for proper ArgoCD sync [airflow]

Posted by "covidium (via GitHub)" <gi...@apache.org>.
covidium commented on PR #41827:
URL: https://github.com/apache/airflow/pull/41827#issuecomment-2315166162

   > IMHO, this change should be done by introducing a new helm value, with 0 by default.
   Will .Values.preSync.hookWeight be OK as the new var?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org