You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Massimo Lusetti (JIRA)" <ta...@jakarta.apache.org> on 2007/02/15 18:18:06 UTC

[jira] Created: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Get remote client IP address through Request wrapper
----------------------------------------------------

                 Key: TAPESTRY-1272
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
             Project: Tapestry
          Issue Type: New Feature
          Components: Core
    Affects Versions: 5.0
            Reporter: Massimo Lusetti
             Fix For: 5.0


Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Posted by "Massimo Lusetti (JIRA)" <ta...@jakarta.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Massimo Lusetti updated TAPESTRY-1272:
--------------------------------------

    Attachment: RemoteIpDemo.java

new page class for remote ip demo

> Get remote client IP address through Request wrapper
> ----------------------------------------------------
>
>                 Key: TAPESTRY-1272
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>             Fix For: 5.0
>
>         Attachments: RemoteIpDemo.html, RemoteIpDemo.java
>
>
> Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Posted by "Massimo Lusetti (JIRA)" <ta...@jakarta.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Massimo Lusetti updated TAPESTRY-1272:
--------------------------------------

    Attachment: remoteIP.diff

diff file to apply to tapestry5 trunk, with integration test

> Get remote client IP address through Request wrapper
> ----------------------------------------------------
>
>                 Key: TAPESTRY-1272
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>             Fix For: 5.0
>
>         Attachments: remoteIP.diff, RemoteIpDemo.html, RemoteIpDemo.java
>
>
> Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Posted by "Massimo Lusetti (JIRA)" <ta...@jakarta.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Massimo Lusetti updated TAPESTRY-1272:
--------------------------------------

    Attachment: RemoteIpDemo.html

new page for remote ip demo

> Get remote client IP address through Request wrapper
> ----------------------------------------------------
>
>                 Key: TAPESTRY-1272
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>             Fix For: 5.0
>
>         Attachments: RemoteIpDemo.html, RemoteIpDemo.java
>
>
> Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Resolved: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Posted by "Massimo Lusetti (JIRA)" <ta...@jakarta.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Massimo Lusetti resolved TAPESTRY-1272.
---------------------------------------

    Resolution: Won't Fix

Well, even if I've used it more then one time i didn't notice the possibility to get the remote IP address from requestGlobals.getHTTPServletRequest().getRemoteAddr() which is more then suitable for my case. Funny.

So i know Howard doesn't need my 'go' to close tapestry issues, but just in case, I'm fine closing this issue.

> Get remote client IP address through Request wrapper
> ----------------------------------------------------
>
>                 Key: TAPESTRY-1272
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>             Fix For: 5.0
>
>         Attachments: remoteIP.diff, RemoteIpDemo.html, RemoteIpDemo.java
>
>
> Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Posted by "Massimo Lusetti (JIRA)" <ta...@jakarta.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475291 ] 

Massimo Lusetti commented on TAPESTRY-1272:
-------------------------------------------

Seems that Howard has already provided Request with a getHeader method which seems suitable for your case.
Check revision r510847.

> Get remote client IP address through Request wrapper
> ----------------------------------------------------
>
>                 Key: TAPESTRY-1272
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>             Fix For: 5.0
>
>         Attachments: remoteIP.diff, RemoteIpDemo.html, RemoteIpDemo.java
>
>
> Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Posted by "Daniel Gredler (JIRA)" <ta...@jakarta.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475226 ] 

Daniel Gredler commented on TAPESTRY-1272:
------------------------------------------

The attached implementation is ineffective if there's a proxy sitting between the client and the application server. Perhaps it could be made to check for the X-Forwarded-For request header?

> Get remote client IP address through Request wrapper
> ----------------------------------------------------
>
>                 Key: TAPESTRY-1272
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>             Fix For: 5.0
>
>         Attachments: remoteIP.diff, RemoteIpDemo.html, RemoteIpDemo.java
>
>
> Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-1272) Get remote client IP address through Request wrapper

Posted by "Daniel Gredler (JIRA)" <ta...@jakarta.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12475329 ] 

Daniel Gredler commented on TAPESTRY-1272:
------------------------------------------

True, but I'd argue that no one is going to call request.getRemoteIp() hoping to get their load balancing server's IP.

> Get remote client IP address through Request wrapper
> ----------------------------------------------------
>
>                 Key: TAPESTRY-1272
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1272
>             Project: Tapestry
>          Issue Type: New Feature
>          Components: Core
>    Affects Versions: 5.0
>            Reporter: Massimo Lusetti
>             Fix For: 5.0
>
>         Attachments: remoteIP.diff, RemoteIpDemo.html, RemoteIpDemo.java
>
>
> Being able to get the IP address of the remote client through the Request wrapper

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org