You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by ka...@apache.org on 2024/03/19 12:30:49 UTC
(druid) branch 29.0.1 updated: Fix FloatFirstVectorAggregationTest (#16165) (#16169)
This is an automated email from the ASF dual-hosted git repository.
karan pushed a commit to branch 29.0.1
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/29.0.1 by this push:
new efe5ec06162 Fix FloatFirstVectorAggregationTest (#16165) (#16169)
efe5ec06162 is described below
commit efe5ec06162aaa6ed862f0dd227aae4a0aa220ae
Author: Karan Kumar <ka...@gmail.com>
AuthorDate: Tue Mar 19 18:00:44 2024 +0530
Fix FloatFirstVectorAggregationTest (#16165) (#16169)
Co-authored-by: Laksh Singla <la...@gmail.com>
---
.../query/aggregation/first/FloatFirstVectorAggregationTest.java | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/processing/src/test/java/org/apache/druid/query/aggregation/first/FloatFirstVectorAggregationTest.java b/processing/src/test/java/org/apache/druid/query/aggregation/first/FloatFirstVectorAggregationTest.java
index 28044de5e4e..a95e89bd32a 100644
--- a/processing/src/test/java/org/apache/druid/query/aggregation/first/FloatFirstVectorAggregationTest.java
+++ b/processing/src/test/java/org/apache/druid/query/aggregation/first/FloatFirstVectorAggregationTest.java
@@ -64,9 +64,7 @@ public class FloatFirstVectorAggregationTest extends InitializedNullHandlingTest
new SerializablePairLongFloat(2345300L, 4.2F)
};
- private final SerializablePairLongFloat[] null_pairs = {
- null, null, null, null
- };
+ private final SerializablePairLongFloat[] nullPairs = {null, null, null, null};
@@ -130,7 +128,7 @@ public class FloatFirstVectorAggregationTest extends InitializedNullHandlingTest
@Override
public Object[] getObjectVector()
{
- return null_pairs;
+ return nullPairs;
}
@Override
@@ -287,7 +285,7 @@ public class FloatFirstVectorAggregationTest extends InitializedNullHandlingTest
target1.aggregate(buf, 0, 0, VALUES.length);
Pair<Long, Float> result = (Pair<Long, Float>) target1.get(buf, 0);
Assert.assertEquals(Long.MAX_VALUE, result.lhs.longValue());
- Assert.assertNull(result.rhs);
+ Assert.assertEquals(NullHandling.defaultFloatValue(), result.rhs);
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org