You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Maurizio Cucchiara (Resolved) (JIRA)" <ji...@apache.org> on 2011/10/29 08:03:32 UTC

[jira] [Resolved] (OGNL-33) [PATCH] Improvements to JJTOgnlParserState

     [ https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Maurizio Cucchiara resolved OGNL-33.
------------------------------------

    Resolution: Fixed
      Assignee: Maurizio Cucchiara

Adrian,
this was a class originally created by javacc, hence I don't know if in the future someone will replace your change with a new generated class.
ATM I applied the patch, b/c i think is a good one.
Thank you again.
                
> [PATCH] Improvements to JJTOgnlParserState
> ------------------------------------------
>
>                 Key: OGNL-33
>                 URL: https://issues.apache.org/jira/browse/OGNL-33
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>         Attachments: patch-OGNL33.txt
>
>
> JJTOgnlParserState was looking a little old school.
> * Introduced generics on the "nodes" and "marks" List.
> * Replaced 1-3 character acronyms with meaningful, camel case variable names.
> * Removed unnecessary use of (un)boxing. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira