You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/03 09:57:32 UTC

[GitHub] [arrow-datafusion] gandronchik commented on a diff in pull request #2334: fix: union schema

gandronchik commented on code in PR #2334:
URL: https://github.com/apache/arrow-datafusion/pull/2334#discussion_r863629908


##########
datafusion/core/src/logical_plan/builder.rs:
##########
@@ -1055,19 +1055,23 @@ pub fn union_with_alias(
     right_plan: LogicalPlan,
     alias: Option<String>,
 ) -> Result<LogicalPlan> {
-    let inputs = vec![left_plan, right_plan]
+    let union_schema = left_plan.schema().clone();
+    let inputs_iter = vec![left_plan, right_plan]

Review Comment:
   Fixed. We still have to clone it to check schema compatibility, however, now the scope is in iteration only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org