You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/13 04:26:41 UTC

[GitHub] [incubator-superset] DiggidyDave commented on a change in pull request #7290: Add celery task to refresh SQL Lab datasources cache

DiggidyDave commented on a change in pull request #7290: Add celery task to refresh SQL Lab datasources cache
URL: https://github.com/apache/incubator-superset/pull/7290#discussion_r275104273
 
 

 ##########
 File path: superset/tasks/cache.py
 ##########
 @@ -316,8 +316,11 @@ def cache_warmup(strategy_name, *args, **kwargs):
     return results
 
 
-@celery_app.task(name='datasources-cache')
-def update_datasources_cache(cache_timeout=24 * 60 * 60):
+def update_datasources(cache_timeout=24 * 60 * 60):
 
 Review comment:
   Rather than having `cli` take a dependency on `tasks`, consider moving this into a shared library that they both depend on so that these two things aren't unnecessarily coupled. (Maybe something under `utils` if there is nothing better in the current code structure?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org