You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Saransh Sharma (Jira)" <ji...@apache.org> on 2020/05/28 12:15:00 UTC

[jira] [Commented] (FINERACT-998) Validate Spring Data JPA *Repository methods

    [ https://issues.apache.org/jira/browse/FINERACT-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118609#comment-17118609 ] 

Saransh Sharma commented on FINERACT-998:
-----------------------------------------

Some comments 

> Validate Spring Data JPA *Repository methods
> --------------------------------------------
>
>                 Key: FINERACT-998
>                 URL: https://issues.apache.org/jira/browse/FINERACT-998
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Priority: Critical
>
> In [https://github.com/apache/fineract/pull/925] for FINERACT-997, [~saransh] noticed that, apparently, the {{ProductToGLAccountMappingRepository}} had a subtle method naming bug which made the query always return empty.
> This made me curious if there wasn't something to make Spring Data JPA detect this kind of problem by itself either (better) at build time, or (also OK) while it starts up and component scans at runtime, and log a clear (ideally fatal..) error about it.
> Maybe this isn't possible, but it strikes me as a basic check Spring should do.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)