[GitHub] [arrow] wesm commented on a change in pull request #8302: ARROW-10121: [C++] Fix emission of new dictionaries in IPC writer

[GitBox <gi...@apache.org>]

wesm commented on a change in pull request #8302:
URL: https://github.com/apache/arrow/pull/8302#discussion_r499856714



##########
File path: cpp/src/arrow/ipc/writer.cc
##########
@@ -982,13 +982,7 @@ class ARROW_EXPORT IpcFormatWriter : public RecordBatchWriter {
 
     RETURN_NOT_OK(CheckStarted());
 
-    if (!wrote_dictionaries_) {
-      RETURN_NOT_OK(WriteDictionaries(batch));
-      wrote_dictionaries_ = true;
-    }
-
-    // TODO: Check for delta dictionaries. Can we scan for deltas while computing
-    // the RecordBatch payload to save time?
+    RETURN_NOT_OK(WriteDictionaries(batch));

Review comment:
       I'm not sure if skipped dictionaries will work, but they are permitted by the format, so it should probably be investigated in a follow up issue




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org