You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/03/20 17:47:49 UTC
[GitHub] [cordova-plugin-statusbar] exxbrain opened a new pull request #181:
Add new styleDarkContent (#164)
exxbrain opened a new pull request #181: Add new styleDarkContent (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
All platforms
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Fixes #164.
It has been already fixed but not correctly. iOS statusbar has different behaviour for Default and Dark styles.
### Description
<!-- Describe your changes in detail -->
Added styleDarkContent similar to styleLightContent
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
Now the default statusbar behaviour has became unavailable in iOS. This pull request fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
Also the default statusbar behaviour has became unavailable in iOS in master branch. This pull request fixes it.
I think it Fixes #162 correctly as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation.
Also default statusbar behaviour becomes unavailable in iOS. I'm not sure it is reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
The default statusbar behaviour has became unavailable in iOS. This pull request fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation.
Also default statusbar behaviour becomes unavailable in iOS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] NiklasMerz commented on issue #181: Add
new styleDarkContent with possibility of selection of default style that is
very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602438882
To me this makes more sense. Otherwise I have to implement app logic to set the right statusbar color and what makes this harder that there is no explicit dark style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
Also the default statusbar behaviour has became unavailable for iOS in master branch. This pull request fixes it.
I think it Fixes #162 correctly as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
The default statusbar behaviour has became unavailable in iOS. This pull request fixes it.
I think it Fixes #162 correctly as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
Also the default statusbar behaviour has became unavailable for iOS13 in master branch. This pull request fixes it.
I think it Fixes #162 correctly as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain commented on issue #181: Add
new styleDarkContent with possibility of selection of default style that is
very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain commented on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
Now the default statusbar behaviour have became unavailable in iOS. This pull request fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
Now the default statusbar behaviour became unavailable in iOS. This pull request fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
The default statusbar behaviour has became unavailable in iOS. This pull request fixes it.
I think it Fixes #162, Fixes #136 correctly as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
The default statusbar behaviour has became unavailable in iOS. This pull request fixes it.
I think it fixes #162 as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
Also default statusbar behaviour becomes unavailable in iOS. I'm not sure it is reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] jcesarmobile commented on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602041386
I proposed this in https://github.com/apache/cordova-plugin-statusbar/issues/165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-statusbar] exxbrain edited a comment on issue #181:
Add new styleDarkContent with possibility of selection of default style
that is very important for iOS (#164)
Posted by GitBox <gi...@apache.org>.
exxbrain edited a comment on issue #181: Add new styleDarkContent with possibility of selection of default style that is very important for iOS (#164)
URL: https://github.com/apache/cordova-plugin-statusbar/pull/181#issuecomment-602174847
> I proposed this in #165, but looks like people wanted "default" to be the dark as it used to be, that's why it was implemented like that.
Unfortunately such solution may be confusing in the future because of difference between plugin behaviour and platform documentation for default style. The behaviour was changed in iOS. I think it will be reasonable to do the same for this plugin.
The default statusbar behaviour has became unavailable in iOS. This pull request fixes it.
I think it fixes #162 correctly as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org