You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Deepal Jayasinghe (JIRA)" <ji...@apache.org> on 2006/11/09 12:06:37 UTC
[jira] Created: (AXIS2-1657) Problems in generated CallbackHandler
in client side
Problems in generated CallbackHandler in client side
----------------------------------------------------
Key: AXIS2-1657
URL: http://issues.apache.org/jira/browse/AXIS2-1657
Project: Apache Axis 2.0 (Axis2)
Issue Type: Improvement
Components: codegen
Affects Versions: nightly
Reporter: Deepal Jayasinghe
When I generate client side code it generates a CallbackHandler abstract class , but the issue with that is it does not have any abstract methods. So I think we should generate that class with abstract methods then user can easily understand what he needs to do. Sample CallBackHandler class is attached below;
public abstract class DateServerCallbackHandler {
protected Object clientData;
public DateServerCallbackHandler(Object clientData) {
this.clientData = clientData;
}
public DateServerCallbackHandler() {
this.clientData = null;
}
public Object getClientData() {
return clientData;
}
public void receiveResultgetDates(
com.mydomain.service.xsd.DateServerStub.GetDatesResponse param1) {
}
public void receiveErrorgetDates(java.lang.Exception e) {
}
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Resolved: (AXIS2-1657) Problems in generated CallbackHandler
in client side
Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amila Chinthaka Suriarachchi resolved AXIS2-1657.
-------------------------------------------------
Resolution: Fixed
add the method header comments
> Problems in generated CallbackHandler in client side
> ----------------------------------------------------
>
> Key: AXIS2-1657
> URL: https://issues.apache.org/jira/browse/AXIS2-1657
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: codegen
> Affects Versions: nightly
> Reporter: Deepal Jayasinghe
> Assigned To: Amila Chinthaka Suriarachchi
>
> When I generate client side code it generates a CallbackHandler abstract class , but the issue with that is it does not have any abstract methods. So I think we should generate that class with abstract methods then user can easily understand what he needs to do. Sample CallBackHandler class is attached below;
> public abstract class DateServerCallbackHandler {
> protected Object clientData;
> public DateServerCallbackHandler(Object clientData) {
> this.clientData = clientData;
> }
> public DateServerCallbackHandler() {
> this.clientData = null;
> }
> public Object getClientData() {
> return clientData;
> }
> public void receiveResultgetDates(
> com.mydomain.service.xsd.DateServerStub.GetDatesResponse param1) {
> }
> public void receiveErrorgetDates(java.lang.Exception e) {
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Updated: (AXIS2-1657) Problems in generated CallbackHandler
in client side
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AXIS2-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Davanum Srinivas updated AXIS2-1657:
------------------------------------
Assignee: Amila Chinthaka Suriarachchi
> Problems in generated CallbackHandler in client side
> ----------------------------------------------------
>
> Key: AXIS2-1657
> URL: https://issues.apache.org/jira/browse/AXIS2-1657
> Project: Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: codegen
> Affects Versions: nightly
> Reporter: Deepal Jayasinghe
> Assigned To: Amila Chinthaka Suriarachchi
>
> When I generate client side code it generates a CallbackHandler abstract class , but the issue with that is it does not have any abstract methods. So I think we should generate that class with abstract methods then user can easily understand what he needs to do. Sample CallBackHandler class is attached below;
> public abstract class DateServerCallbackHandler {
> protected Object clientData;
> public DateServerCallbackHandler(Object clientData) {
> this.clientData = clientData;
> }
> public DateServerCallbackHandler() {
> this.clientData = null;
> }
> public Object getClientData() {
> return clientData;
> }
> public void receiveResultgetDates(
> com.mydomain.service.xsd.DateServerStub.GetDatesResponse param1) {
> }
> public void receiveErrorgetDates(java.lang.Exception e) {
> }
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-1657) Problems in generated
CallbackHandler in client side
Posted by "Dennis Sosnoski (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-1657?page=comments#action_12448575 ]
Dennis Sosnoski commented on AXIS2-1657:
----------------------------------------
The problem with using abstract methods is that the user then has to implement *all* of them. In the case of a service interface with multiple operations this gets very cumbersome (especially when the user only wants to use one operation asynchronously).
A better solution is to add comments to the template to explain what should be overridden. This could take the form of:
// user data object
protected Object clientData;
...
// override this method for handling normal response from getDates operation
public void receiveResultgetDates(
...
// override this method for handling error response from getDates operation
public void receiveErrorgetDates(java.lang.Exception e) {
...
> Problems in generated CallbackHandler in client side
> ----------------------------------------------------
>
> Key: AXIS2-1657
> URL: http://issues.apache.org/jira/browse/AXIS2-1657
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: codegen
> Affects Versions: nightly
> Reporter: Deepal Jayasinghe
>
> When I generate client side code it generates a CallbackHandler abstract class , but the issue with that is it does not have any abstract methods. So I think we should generate that class with abstract methods then user can easily understand what he needs to do. Sample CallBackHandler class is attached below;
> public abstract class DateServerCallbackHandler {
> protected Object clientData;
> public DateServerCallbackHandler(Object clientData) {
> this.clientData = clientData;
> }
> public DateServerCallbackHandler() {
> this.clientData = null;
> }
> public Object getClientData() {
> return clientData;
> }
> public void receiveResultgetDates(
> com.mydomain.service.xsd.DateServerStub.GetDatesResponse param1) {
> }
> public void receiveErrorgetDates(java.lang.Exception e) {
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org
[jira] Commented: (AXIS2-1657) Problems in generated
CallbackHandler in client side
Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/AXIS2-1657?page=comments#action_12448652 ]
Davanum Srinivas commented on AXIS2-1657:
-----------------------------------------
+1 to dennis' suggestion
> Problems in generated CallbackHandler in client side
> ----------------------------------------------------
>
> Key: AXIS2-1657
> URL: http://issues.apache.org/jira/browse/AXIS2-1657
> Project: Apache Axis 2.0 (Axis2)
> Issue Type: Improvement
> Components: codegen
> Affects Versions: nightly
> Reporter: Deepal Jayasinghe
>
> When I generate client side code it generates a CallbackHandler abstract class , but the issue with that is it does not have any abstract methods. So I think we should generate that class with abstract methods then user can easily understand what he needs to do. Sample CallBackHandler class is attached below;
> public abstract class DateServerCallbackHandler {
> protected Object clientData;
> public DateServerCallbackHandler(Object clientData) {
> this.clientData = clientData;
> }
> public DateServerCallbackHandler() {
> this.clientData = null;
> }
> public Object getClientData() {
> return clientData;
> }
> public void receiveResultgetDates(
> com.mydomain.service.xsd.DateServerStub.GetDatesResponse param1) {
> }
> public void receiveErrorgetDates(java.lang.Exception e) {
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org