You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/01 12:05:12 UTC

[GitHub] [rocketmq] RongtongJin opened a new pull request, #4757: Timer Message adapts to slaveActingMaster mode

RongtongJin opened a new pull request, #4757:
URL: https://github.com/apache/rocketmq/pull/4757

**Make sure set the target branch to `develop`**

## What is the purpose of the change

Timer Message adapts to slaveActingMaster mode

## Brief changelog

Timer Message adapts to slaveActingMaster mode

## Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ShannonDing merged pull request #4757: [ISSUE #4758] Timer Message adapts to slaveActingMaster mode

Posted by GitBox <gi...@apache.org>.

ShannonDing merged PR #4757:
URL: https://github.com/apache/rocketmq/pull/4757


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4757: [ISSUE #4758] Timer Message adapts to slaveActingMaster mode

Posted by GitBox <gi...@apache.org>.

coveralls commented on PR #4757:
URL: https://github.com/apache/rocketmq/pull/4757#issuecomment-1201165552

   
   [![Coverage Status](https://coveralls.io/builds/51310823/badge)](https://coveralls.io/builds/51310823)
   
   Coverage increased (+0.06%) to 48.913% when pulling **e8caacd0fb7c5c8242208cf4664cc47d051a9e1b on RongtongJin:timer-slave-acting-master** into **6a95661291a7a94e55b6813d5298b58a779aea2b on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4757: [ISSUE #4758] Timer Message adapts to slaveActingMaster mode

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on PR #4757:
URL: https://github.com/apache/rocketmq/pull/4757#issuecomment-1201207405

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4757?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4757](https://codecov.io/gh/apache/rocketmq/pull/4757?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e8caacd) into [develop](https://codecov.io/gh/apache/rocketmq/commit/3c36a19cbd7d9abcc1b4523a8d360fd94d0c7b4a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c36a19) will **increase** coverage by `0.11%`.
   > The diff coverage is `50.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4757      +/-   ##
   =============================================
   + Coverage      44.72%   44.84%   +0.11%     
   - Complexity      7552     7584      +32     
   =============================================
     Files            977      977              
     Lines          67781    67823      +42     
     Branches        8960     8964       +4     
   =============================================
   + Hits           30317    30413      +96     
   + Misses         33705    33661      -44     
   + Partials        3759     3749      -10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4757?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...apache/rocketmq/broker/BrokerPreOnlineService.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyUHJlT25saW5lU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...apache/rocketmq/store/timer/TimerMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyTWVzc2FnZVN0b3JlLmphdmE=) | `54.28% <36.36%> (+0.18%)` | :arrow_up: |
   | [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `43.97% <66.66%> (+0.06%)` | :arrow_up: |
   | [...g/apache/rocketmq/store/timer/TimerCheckpoint.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3RpbWVyL1RpbWVyQ2hlY2twb2ludC5qYXZh) | `91.39% <90.90%> (+24.73%)` | :arrow_up: |
   | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: |
   | [...a/org/apache/rocketmq/filter/util/BloomFilter.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CbG9vbUZpbHRlci5qYXZh) | `60.43% <0.00%> (-2.20%)` | :arrow_down: |
   | [...org/apache/rocketmq/store/ha/DefaultHAService.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL2hhL0RlZmF1bHRIQVNlcnZpY2UuamF2YQ==) | `67.48% <0.00%> (-1.85%)` | :arrow_down: |
   | [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `44.37% <0.00%> (-0.38%)` | :arrow_down: |
   | [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `64.39% <0.00%> (-0.32%)` | :arrow_down: |
   | [...org/apache/rocketmq/store/DefaultMessageStore.java](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0RlZmF1bHRNZXNzYWdlU3RvcmUuamF2YQ==) | `55.53% <0.00%> (-0.16%)` | :arrow_down: |
   | ... and [24 more](https://codecov.io/gh/apache/rocketmq/pull/4757/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4757: [ISSUE #4758] Timer Message adapts to slaveActingMaster mode

Posted by GitBox <gi...@apache.org>.

coveralls commented on PR #4757:
URL: https://github.com/apache/rocketmq/pull/4757#issuecomment-1201165545

   
   [![Coverage Status](https://coveralls.io/builds/51310823/badge)](https://coveralls.io/builds/51310823)
   
   Coverage increased (+0.06%) to 48.913% when pulling **e8caacd0fb7c5c8242208cf4664cc47d051a9e1b on RongtongJin:timer-slave-acting-master** into **6a95661291a7a94e55b6813d5298b58a779aea2b on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org