You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/11/21 13:01:07 UTC

[GitHub] [openwhisk] markusthoemmes opened a new pull request #4743: Simplify Option.filter(identity) pattern to something actually readable.

markusthoemmes opened a new pull request #4743: Simplify Option.filter(identity) pattern to something actually readable.
URL: https://github.com/apache/openwhisk/pull/4743
 
 
   <!--- Provide a concise summary of your changes in the Title -->
   
   ## Description
   I used to love to write "smart" code like `Some(descending).filter(identity)`. Coming back to it now, I hate it though. It feels unreadable, especially if there are simpler yet similar terse alternatives.
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [X] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services