You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/22 10:48:44 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #19476: Move EncryptRuleConfiguration check logic from EncryptRule to EncryptRuleConfigurationChecker
strongduanmu opened a new pull request, #19476:
URL: https://github.com/apache/shardingsphere/pull/19476
Ref #19102.
Changes proposed in this pull request:
- move EncryptRuleConfiguration check logic from EncryptRule to EncryptRuleConfigurationChecker
- add unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19476: Move EncryptRuleConfiguration check logic from EncryptRule to EncryptRuleConfigurationChecker
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19476:
URL: https://github.com/apache/shardingsphere/pull/19476#issuecomment-1192552040
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19476?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19476](https://codecov.io/gh/apache/shardingsphere/pull/19476?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (af7bbdc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/2d23dee0c0eecfe5fdfdfe3bc3c489197c9da90e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d23dee) will **decrease** coverage by `0.00%`.
> The diff coverage is `79.06%`.
```diff
@@ Coverage Diff @@
## master #19476 +/- ##
============================================
- Coverage 59.88% 59.87% -0.01%
Complexity 2384 2384
============================================
Files 3823 3823
Lines 54440 54435 -5
Branches 7622 7611 -11
============================================
- Hits 32599 32593 -6
- Misses 19051 19059 +8
+ Partials 2790 2783 -7
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19476?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/shardingsphere/encrypt/rule/EncryptRule.java](https://codecov.io/gh/apache/shardingsphere/pull/19476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcnVsZS9FbmNyeXB0UnVsZS5qYXZh) | `83.60% <ø> (+7.78%)` | :arrow_up: |
| [...ecker/AbstractEncryptRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/19476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvY2hlY2tlci9BYnN0cmFjdEVuY3J5cHRSdWxlQ29uZmlndXJhdGlvbkNoZWNrZXIuamF2YQ==) | `61.53% <62.50%> (-38.47%)` | :arrow_down: |
| [...orithmProvidedEncryptRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/19476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvY2hlY2tlci9BbGdvcml0aG1Qcm92aWRlZEVuY3J5cHRSdWxlQ29uZmlndXJhdGlvbkNoZWNrZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...crypt/checker/EncryptRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/19476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvY2hlY2tlci9FbmNyeXB0UnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...actReadwriteSplittingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/19476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9jaGVja2VyL0Fic3RyYWN0UmVhZHdyaXRlU3BsaXR0aW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `100.00% <100.00%> (ø)` | |
| [...cker/AbstractShardingRuleConfigurationChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/19476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvY2hlY2tlci9BYnN0cmFjdFNoYXJkaW5nUnVsZUNvbmZpZ3VyYXRpb25DaGVja2VyLmphdmE=) | `73.68% <100.00%> (ø)` | |
| [...nd/text/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/19476/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #19476: Move EncryptRuleConfiguration check logic from EncryptRule to EncryptRuleConfigurationChecker
Posted by GitBox <gi...@apache.org>.
zjcnb merged PR #19476:
URL: https://github.com/apache/shardingsphere/pull/19476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org