You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/07/19 13:43:54 UTC
[GitHub] [maven-integration-testing] rfscholte opened a new pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
rfscholte opened a new pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#discussion_r672611736
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
According to https://maven.apache.org/ref/current/maven-core/apidocs/org/apache/maven/plugin/PluginParameterExpressionEvaluator.html it is still valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#issuecomment-883256958
Will adjust the commit message after the squash and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#discussion_r672616179
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
My bad, it is indeed still valid...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#discussion_r672604359
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
Isn't this deprecated for `{project.basedir}`?
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
My bad, it is indeed still valid...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#discussion_r672604359
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
Isn't this deprecated for `{project.basedir}`?
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
My bad, it is indeed still valid...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#discussion_r672611736
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
According to https://maven.apache.org/ref/current/maven-core/apidocs/org/apache/maven/plugin/PluginParameterExpressionEvaluator.html it is still valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on a change in pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on a change in pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#discussion_r672611736
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
According to https://maven.apache.org/ref/current/maven-core/apidocs/org/apache/maven/plugin/PluginParameterExpressionEvaluator.html it is still valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] asfgit closed pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a change in pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#discussion_r672604359
##########
File path: core-it-suite/src/test/resources/mng-6759-transitive-dependency-repositories/module2/pom.xml
##########
@@ -11,7 +11,7 @@
<repositories>
<repository>
<id>customRepo</id>
- <url>${custom.repo.uri}</url>
+ <url>file:///${basedir}/../dependency-in-custom-repo/target/repo</url>
Review comment:
Isn't this deprecated for `{project.basedir}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] rfscholte commented on pull request #108: [MNG-6271] Add validationRule for expressions in repositoryUrl
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #108:
URL: https://github.com/apache/maven-integration-testing/pull/108#issuecomment-883256958
Will adjust the commit message after the squash and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org