[GitHub] [arrow-datafusion] liukun4515 commented on pull request #2834: InList: set/list value must be evaluated to get the values

[GitBox <gi...@apache.org>]

liukun4515 commented on PR #2834:
URL: https://github.com/apache/arrow-datafusion/pull/2834#issuecomment-1175730534

   > I think this PR is an improvement. Thank you @liukun4515
   > 
   > I left a suggestion on how to maybe make the check more general (aka not have to special case different expression types).
   
   Thanks for you suggestion about `evel const value`.
   I have changed the code according to your suggestion.
   ```
   let batch = RecordBatch::new_empty(Arc::new(schema.to_owned()));
       list.iter().all(|v| match v.evaluate(&batch) {
           Err(_) | Ok(ColumnarValue::Array(_)) => false,
           Ok(ColumnarValue::Scalar(_)) => true,
       })
   ```
   PTAL @alamb 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org