[GitHub] XD-DENG commented on a change in pull request #4521: [AIRFLOW-3704] Support SSL Protection When Redis is Used as Broker for CeleryExecutor

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #4521: [AIRFLOW-3704] Support SSL Protection When Redis is Used as Broker for CeleryExecutor
URL: https://github.com/apache/airflow/pull/4521#discussion_r247507299
 
 

 ##########
 File path: airflow/config_templates/default_celery.py
 ##########
 @@ -75,6 +85,6 @@ def _broker_supports_visibility_timeout(url):
                            'SSL and/or have all necessary certs and key ({}).'.format(e))
 
 result_backend = DEFAULT_CELERY_CONFIG['result_backend']
-if 'amqp' in result_backend or 'redis' in result_backend or 'rpc' in result_backend:
+if 'amqp://' in result_backend or 'redis://' in result_backend or 'rpc://' in result_backend:
 
 Review comment:
   This change is to address cases like `mysql://amqp:password@localhost` (i.e., "amqp" or "redis" may happen to be part of my user name).
   
   It's not really relating to this PR subject. But this may not be worthwhile to open another PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services