You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "cylx3126 (via GitHub)" <gi...@apache.org> on 2024/03/12 14:03:11 UTC
[PR] Fix a bug in hc5: when the arg HttpHost of InternalHttpClient#doExecute is null, hc5 would send request but the agent don't create span [skywalking-java]
cylx3126 opened a new pull request, #674:
URL: https://github.com/apache/skywalking-java/pull/674
[MRE here](https://github.com/cylx3126/skywalking-hc5-losespan-mre).
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix not tracing in HttpClient v5 when HttpHost(arg[0]) is null but `RoutingSupport#determineHost` works. [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #674:
URL: https://github.com/apache/skywalking-java/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix a bug in hc5: when the arg HttpHost of InternalHttpClient#doExecute is null, hc5 would send request but the agent don't create span [skywalking-java]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #674:
URL: https://github.com/apache/skywalking-java/pull/674#discussion_r1521592423
##########
CHANGES.md:
##########
@@ -17,6 +17,7 @@ Release Notes.
* Support for ActiveMQ-Artemis messaging tracing.
* Archive the expired plugins `impala-jdbc-2.6.x-plugin`.
* Fix a bug in Spring Cloud Gateway if HttpClientFinalizer#send does not invoke, the span created at NettyRoutingFilterInterceptor can not stop.
+* Fix a bug in hc5: when the arg HttpHost of InternalHttpClient#doExecute is null, hc5 would send request but the agent don't create span
Review Comment:
```suggestion
* Fix not tracing in HttpClient v5 when HttpHost(arg[0]) is null but `RoutingSupport#determineHost` works.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org