You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/07 02:00:55 UTC
[GitHub] [incubator-seatunnel] ashulin opened a new pull request, #2665: [Improve][build] Improved scope of maven-shade-plugin
ashulin opened a new pull request, #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
Improved scope of maven-shade-plugin
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1239213306
> @CalvinKirs @EricJoy2048 If declared in the parent pom, it will cause `connector-common`, `connector-file-base`, etc. to also execute the shaded.
Can we use `exclude` to exclude `connector-common`, `connector-file-base`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1239217668
> > @CalvinKirs @EricJoy2048 If declared in the parent pom, it will cause `connector-common`, `connector-file-base`, etc. to also execute the shaded.
>
> Can we use `exclude` to exclude `connector-common`, `connector-file-base`?
We can manually declare the plugin in these special modules and then add the`skip` parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1238829238
ZonedDateTime should be solved by another PR as an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin merged pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
ashulin merged PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
hailin0 commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1238961049
Need to exclude slf4j, logback, log4j, other... in connector shade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1238858415
> How about declaring in parent dependency? This way you don't have to declare every submodule
Yes, I think so, too.
Add `maven-shade-plugin` to `seatunnel-connector-v2/pom.xml` instead `seatunnel-connector-v2/connector-xxx/pom.xml` is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1238852537
@CalvinKirs @TyrantLucifer @laglangyue PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1239289311
@CalvinKirs @EricJoy2048 Thanks, I got it. maven-shade-plugin provided the `skip` parameter in the latest version(3.3.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#issuecomment-1239108704
@CalvinKirs @EricJoy2048 If declared in the parent pom, it will cause `connector-common`, `connector-file-base`, etc. to also execute the shaded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2665: [Improve][build] Improved scope of maven-shade-plugin
Posted by GitBox <gi...@apache.org>.
ashulin commented on code in PR #2665:
URL: https://github.com/apache/incubator-seatunnel/pull/2665#discussion_r964749808
##########
seatunnel-connectors-v2/connector-dingtalk/pom.xml:
##########
@@ -41,6 +41,12 @@
<groupId>com.aliyun</groupId>
<artifactId>alibaba-dingtalk-service-sdk</artifactId>
<version>${dingtalk.service.version}</version>
+ <exclusions>
+ <exclusion>
+ <artifactId>log4j</artifactId>
+ <groupId>log4j</groupId>
+ </exclusion>
+ </exclusions>
Review Comment:
Excluded due to an error resolving JMX/JMS dependencies at build phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org