[GitHub] [beam] damccorm commented on a diff in pull request #28259: Publish Checkstyle Results

["damccorm (via GitHub)" <gi...@apache.org>]

damccorm commented on code in PR #28259:
URL: https://github.com/apache/beam/pull/28259#discussion_r1312987932


##########
.github/workflows/beam_PreCommit_Spotless.yml:
##########
@@ -94,4 +94,9 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: java-code-coverage-report
-          path: "**/build/reports/checkstyle/*.xml"
\ No newline at end of file
+          path: "**/build/reports/checkstyle/*.xml"
+      - name: Publish checkstyle check
+        uses: jwgmeligmeyling/checkstyle-github-action@master

Review Comment:
   ```suggestion
           uses: jwgmeligmeyling/checkstyle-github-action@v1
   ```
   
   Generally when we use 3rd party actions, we should pin to a tag. This is less likely to randomly break, and the infra team will only allowlist actions that are pinned to tags



##########
.github/workflows/beam_PreCommit_Spotless.yml:
##########
@@ -94,4 +94,9 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: java-code-coverage-report
-          path: "**/build/reports/checkstyle/*.xml"
\ No newline at end of file
+          path: "**/build/reports/checkstyle/*.xml"
+      - name: Publish checkstyle check
+        uses: jwgmeligmeyling/checkstyle-github-action@master

Review Comment:
   I created a jira ticket with infra (may not be publicly visible) to allow list this action @ v1 https://issues.apache.org/jira/browse/INFRA-24948



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org