You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sateesh Chodapuneedi <sa...@citrix.com> on 2012/09/20 14:16:29 UTC
Review Request: Fixes the bug CLOUDSTACK-89 specific to CloudStack
deployment over VMWare vSphere servers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7191/
-----------------------------------------------------------
Review request for cloudstack, Devdeep Singh and Kelven Yang.
Description
-------
Currently we are modifying the context map inside for-each loop directly.
Code change is to use iterator to modify (remove) the entry in the context map.
Fixes CLOUDSTACK-89 (URL - https://issues.apache.org/jira/browse/CLOUDSTACK-89)
Bug summary - VM deployment not working and Exception on SSVM.
This addresses bug CLOUDSTACK-89.
Diffs
-----
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageContextFactory.java fce66a9
Diff: https://reviews.apache.org/r/7191/diff/
Testing
-------
Single zone sanity check done.
Thanks,
Sateesh Chodapuneedi
Re: Review Request: Fixes the bug CLOUDSTACK-89 specific to CloudStack
deployment over VMWare vSphere servers.
Posted by Kelven Yang <ke...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7191/#review11757
-----------------------------------------------------------
Ship it!
Ship It!
- Kelven Yang
On Sept. 20, 2012, 12:16 p.m., Sateesh Chodapuneedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7191/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2012, 12:16 p.m.)
>
>
> Review request for cloudstack, Devdeep Singh and Kelven Yang.
>
>
> Description
> -------
>
> Currently we are modifying the context map inside for-each loop directly.
>
> Code change is to use iterator to modify (remove) the entry in the context map.
>
> Fixes CLOUDSTACK-89 (URL - https://issues.apache.org/jira/browse/CLOUDSTACK-89)
>
> Bug summary - VM deployment not working and Exception on SSVM.
>
>
> This addresses bug CLOUDSTACK-89.
>
>
> Diffs
> -----
>
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageContextFactory.java fce66a9
>
> Diff: https://reviews.apache.org/r/7191/diff/
>
>
> Testing
> -------
>
> Single zone sanity check done.
>
>
> Thanks,
>
> Sateesh Chodapuneedi
>
>