[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1498: SOLR-14351: commitScheduler was missing MDC logging

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1498:
URL: https://github.com/apache/lucene-solr/pull/1498#discussion_r422724167



##########
File path: solr/core/src/java/org/apache/solr/update/CommitTracker.java
##########
@@ -57,8 +58,10 @@
   private int docsUpperBound;
   private long timeUpperBound;
   private long tLogFileSizeUpperBound;
-  
-  private final ScheduledExecutorService scheduler = 
+
+  // note: can't use ExecutorsUtil because it doesn't have a *scheduled* ExecutorService.
+  //  Not a big deal but it means we must take care of MDC logging here.

Review comment:
       I thought of that.  There isn't much need for a ScheduledExecutorService throughout Solr, and it'd probably add a bunch of code over in ExecutorsUtil to add one.  I looked at all that ExecutorsUtil does which is kind of a ton and thought all I really want here is a basic MDC to set the core for logging and that's it.  That said, if you think the usage here ought to be doing more than just this, then we should probably go add stuff to ExecutorsUtil for the Scheduled case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org