You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/02 22:16:37 UTC

[GitHub] [beam] dpcollins-google commented on a change in pull request #15076: Change PubsubLiteIO to reference com.google.cloud.pubsublite.beam.PubsubLiteIO from pubsublite-beam-io package

dpcollins-google commented on a change in pull request #15076:
URL: https://github.com/apache/beam/pull/15076#discussion_r663267690



##########
File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -621,6 +621,7 @@ class BeamModulePlugin implements Plugin<Project> {
         proto_google_cloud_spanner_v1: "com.google.api.grpc:proto-google-cloud-spanner-v1", // google_cloud_platform_libraries_bom sets version
         proto_google_cloud_spanner_admin_database_v1: "com.google.api.grpc:proto-google-cloud-spanner-admin-database-v1", // google_cloud_platform_libraries_bom sets version
         proto_google_common_protos                  : "com.google.api.grpc:proto-google-common-protos", // google_cloud_platform_libraries_bom sets version
+        pubsublite_beam_io                          : "com.google.cloud:pubsublite-beam-io:$google_cloud_pubsublite_version",

Review comment:
       I'll change the variable name to "google_cloud_pubsublite_beam_io" so it can both remain alphabetical and be sorted up there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org