You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/11/10 13:13:09 UTC
[GitHub] [maven] gnodet opened a new pull request #608: [MNG-7329] Upgrade maven-enforcer-plugin
gnodet opened a new pull request #608:
URL: https://github.com/apache/maven/pull/608
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #608: [MNG-7329] Upgrade maven-enforcer-plugin
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #608:
URL: https://github.com/apache/maven/pull/608#issuecomment-965136763
> Is this a work-around for the fact that [apache/maven-parent#32](https://github.com/apache/maven-parent/pull/32) has not yet been released? Based on what @cstamas said in [MNG-7319](https://issues.apache.org/jira/browse/MNG-7319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437157#comment-17437157), I guess that latter is the long-term fix.
This definitely is the same issue, I missed it as I have been looking for a PR.
Imho, having master not building correctly should be fixed asap, so what about quickly include this PR and eventually revert when maven-parent is released ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #608: [MNG-7329] Upgrade maven-enforcer-plugin
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #608:
URL: https://github.com/apache/maven/pull/608#issuecomment-965317212
> But updating it for Maven only (as this PR does) is most likely the _fastest_ way forward. The only thing I'm afraid of is that we will forget to remove this quick patch when maven-parent is released...
I've raised https://issues.apache.org/jira/browse/MNG-7330 to not forget it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #608: [MNG-7329] Upgrade maven-enforcer-plugin
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #608:
URL: https://github.com/apache/maven/pull/608#issuecomment-965140793
> Imho, having master not building correctly should be fixed asap
Most certainly agree. We shouldn't even let it come this far (but that's a different topic).
> What about quickly include this PR and eventually revert when maven-parent is released?
I don't know how much work it would be to release maven-parent. I feel that would be "the right way" to solve it. But updating it for Maven only (as this PR does) is most likely the _fastest_ way forward. The only thing I'm afraid of is that we will forget to remove this quick patch when maven-parent is released...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #608: [MNG-7329] Upgrade maven-enforcer-plugin
Posted by GitBox <gi...@apache.org>.
gnodet merged pull request #608:
URL: https://github.com/apache/maven/pull/608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #608: [MNG-7329] Upgrade maven-enforcer-plugin
Posted by GitBox <gi...@apache.org>.
mthmulders commented on pull request #608:
URL: https://github.com/apache/maven/pull/608#issuecomment-965128304
Is this a work-around for the fact that https://github.com/apache/maven-parent/pull/32 has not yet been released? Based on what @cstamas said in [MNG-7319](https://issues.apache.org/jira/browse/MNG-7319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437157#comment-17437157), I guess that latter is the long-term fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #608: [MNG-7329] Upgrade maven-enforcer-plugin
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on pull request #608:
URL: https://github.com/apache/maven/pull/608#issuecomment-965250548
We have also m-e-p version in ASF parent pom
and was updated https://github.com/apache/maven-apache-parent/commit/9e195c86baada07b2a1a493ca7eed622d0482b36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org