You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/22 13:18:18 UTC

[GitHub] [flink] fsk119 commented on a change in pull request #13800: [FLINK-19650][connectors jdbc]Support the limit push down for the Jdb…

fsk119 commented on a change in pull request #13800:
URL: https://github.com/apache/flink/pull/13800#discussion_r547272739



##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala
##########
@@ -244,6 +244,7 @@ object FlinkStreamRuleSets {
     PushProjectIntoLegacyTableSourceScanRule.INSTANCE,
     PushFilterIntoTableSourceScanRule.INSTANCE,
     PushFilterIntoLegacyTableSourceScanRule.INSTANCE,
+    PushLimitIntoTableSourceScanRule.INSTANCE,

Review comment:
       They only add the rule into `BatchRuleSet`. I add a new commit to test the rule under the StreamEnvironment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org