[GitHub] [pulsar] eolivelli commented on a change in pull request #11697: [server] Fixed Casting Error

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11697:
URL: https://github.com/apache/pulsar/pull/11697#discussion_r691319160



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##########
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.service;
+
+import org.apache.pulsar.broker.PulsarService;
+import org.apache.pulsar.broker.ServiceConfiguration;
+import org.apache.pulsar.broker.cache.ConfigurationCacheService;
+import org.testng.annotations.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.testng.Assert.assertEquals;
+
+@Test(groups = "broker")
+public class BacklogQuotaManagerConfigurationTest {
+
+    @Test
+    public void testBacklogQuotaDefaultLimitGBConversion() {
+        ServiceConfiguration serviceConfiguration = new ServiceConfiguration();
+        initializeServiceConfiguration(serviceConfiguration);
+

Review comment:
       can we set here this ?
   `serviceConfiguration.setBacklogQuotaDefaultLimitGB(1.6);`
   
   otherwise is it quite tricky to see where 1717986918 comes from

##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BacklogQuotaManagerConfigurationTest.java
##########
@@ -0,0 +1,82 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.broker.service;
+
+import org.apache.pulsar.broker.PulsarService;
+import org.apache.pulsar.broker.ServiceConfiguration;
+import org.apache.pulsar.broker.cache.ConfigurationCacheService;
+import org.testng.annotations.Test;
+
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+import static org.testng.Assert.assertEquals;
+
+@Test(groups = "broker")
+public class BacklogQuotaManagerConfigurationTest {
+
+    @Test
+    public void testBacklogQuotaDefaultLimitGBConversion() {
+        ServiceConfiguration serviceConfiguration = new ServiceConfiguration();
+        initializeServiceConfiguration(serviceConfiguration);
+
+        PulsarService pulsarService = getPulsarService(serviceConfiguration);
+        BacklogQuotaManager backlogQuotaManager = new BacklogQuotaManager(pulsarService);
+
+        assertEquals(backlogQuotaManager.getDefaultQuota().getLimitSize(), 1717986918);
+    }
+
+    @Test
+    public void testBacklogQuotaDefaultLimitPrecedence() {
+        ServiceConfiguration serviceConfiguration = new ServiceConfiguration();
+        initializeServiceConfiguration(serviceConfiguration);
+        serviceConfiguration.setBacklogQuotaDefaultLimitBytes(123);

Review comment:
       can we set here this ?
   `serviceConfiguration.setBacklogQuotaDefaultLimitGB(1.6);`
   
   otherwise is it quite tricky to see where 1717986918 comes from




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org