You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/03/11 18:01:37 UTC

Review Request 19053: API call for toggling maintenance mode (updating Nagios alerts) does not show any logs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19053/
-----------------------------------------------------------

Review request for Ambari, Sid Wagle and Tom Beerbower.


Bugs: AMBARI-5022
    https://issues.apache.org/jira/browse/AMBARI-5022


Repository: ambari


Description
-------

Simple patch to add output to the custom command that suppresses Nagios alerts.  The output shows in the task list in the UI.


Diffs
-----

  ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py 7618d93 

Diff: https://reviews.apache.org/r/19053/diff/


Testing
-------

No additional testing required, only logging.  Plus, I have a separate JIRA already for making test cases on custom actions.


Thanks,

Nate Cole


Re: Review Request 19053: API call for toggling maintenance mode (updating Nagios alerts) does not show any logs

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19053/#review36808
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On March 11, 2014, 5:01 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19053/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 5:01 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5022
>     https://issues.apache.org/jira/browse/AMBARI-5022
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Simple patch to add output to the custom command that suppresses Nagios alerts.  The output shows in the task list in the UI.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py 7618d93 
> 
> Diff: https://reviews.apache.org/r/19053/diff/
> 
> 
> Testing
> -------
> 
> No additional testing required, only logging.  Plus, I have a separate JIRA already for making test cases on custom actions.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 19053: API call for toggling maintenance mode (updating Nagios alerts) does not show any logs

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19053/#review36810
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On March 11, 2014, 5:01 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19053/
> -----------------------------------------------------------
> 
> (Updated March 11, 2014, 5:01 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Tom Beerbower.
> 
> 
> Bugs: AMBARI-5022
>     https://issues.apache.org/jira/browse/AMBARI-5022
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Simple patch to add output to the custom command that suppresses Nagios alerts.  The output shows in the task list in the UI.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/custom_actions/nagios_update_ignore.py 7618d93 
> 
> Diff: https://reviews.apache.org/r/19053/diff/
> 
> 
> Testing
> -------
> 
> No additional testing required, only logging.  Plus, I have a separate JIRA already for making test cases on custom actions.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>