Re: [PR] fix: initialize large-binary S3 bucket at startup to prevent NoSuchBucketException [texera]

["aicam (via GitHub)" <gi...@apache.org>]

aicam commented on code in PR #4241:
URL: https://github.com/apache/texera/pull/4241#discussion_r2961289165


##########
amber/src/main/scala/org/apache/texera/web/TexeraWebApplication.scala:
##########
@@ -104,6 +105,9 @@ class TexeraWebApplication
       StorageConfig.jdbcPassword
     )
 
+    // ensure the large-binary S3 bucket exists before any workflow execution attempts to use it
+    LargeBinaryManager.initialize()

Review Comment:
   Can we move this to `file-service/src/main/scala/org/apache/texera/service/FileService.scala` (check line 72) to be consistent?



##########
common/workflow-core/src/main/scala/org/apache/texera/service/util/LargeBinaryManager.scala:
##########
@@ -32,15 +32,20 @@ import java.util.UUID
 object LargeBinaryManager extends LazyLogging {
   private val DEFAULT_BUCKET = "texera-large-binaries"
 
+  /**
+    * Ensures the large-binary bucket exists. Should be called once at service startup.
+    */
+  def initialize(): Unit = {

Review Comment:
   I believe this function is redundant, it is a function that just calls another function, please refer to `file-service/src/main/scala/org/apache/texera/service/FileService.scala`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org