[GitHub] [helix] dasahcc commented on a change in pull request #882: Change the REST call for delete CloudConfig

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #882: Change the REST call for delete CloudConfig 
URL: https://github.com/apache/helix/pull/882#discussion_r390514649
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
 ##########
 @@ -617,10 +630,6 @@ public Response updateCloudConfig(@PathParam("clusterId") String clusterId,
     }
     try {
       switch (command) {
-      case delete: {
-        admin.removeCloudConfig(clusterId);
-      }
-      break;
       case update: {
         try {
           CloudConfig cloudConfig = new CloudConfig.Builder(record).build();
 
 Review comment:
   Can you have another PR like Molly's work? The update/delete for a cloudConfig is working on update/delete entry of the CloudConfig.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org