You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/01/17 20:38:00 UTC

[jira] [Commented] (AVRO-1577) TestSpecificCompiler is not closing resources

    [ https://issues.apache.org/jira/browse/AVRO-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16745480#comment-16745480 ] 

ASF subversion and git services commented on AVRO-1577:
-------------------------------------------------------

Commit 411cfb96db6126a06df9e8093106e690b7e35dfc in avro's branch refs/heads/master from Daniel Kulp
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=411cfb9 ]

[AVRO-1577] Update couple more methods to use try-with-resources


> TestSpecificCompiler is not closing resources
> ---------------------------------------------
>
>                 Key: AVRO-1577
>                 URL: https://issues.apache.org/jira/browse/AVRO-1577
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.7.7
>         Environment: Windows
>            Reporter: Stevo Slavic
>            Priority: Major
>             Fix For: 1.9.0
>
>         Attachments: AVRO-1577.patch
>
>
> Test methods in {{TestSpecificCompiler}} are opening various {{Closable}} resources, but they are not closing them. Because of this, file deletion in {{tearDown}} silently fails (on platforms like Windows which are locking files that are being used). This causes few test methods to fail since they are using same temp file as output file - they generate new file content but only if file is not already present, and then assertions comparing actual and expected output content fail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)