[GitHub] [ozone] ChenSammi commented on a change in pull request #2591: HDDS-5690. Speed up TestContainerReplication by removing testSkipDemmissionAndMaintenanceNode

[GitBox <gi...@apache.org>]

ChenSammi commented on a change in pull request #2591:
URL: https://github.com/apache/ozone/pull/2591#discussion_r697403608



##########
File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java
##########
@@ -524,4 +527,33 @@ public void testvalidateContainerPlacementSingleRackCluster() {
     assertTrue(stat.isPolicySatisfied());
     assertEquals(0, stat.misReplicationCount());
   }
+
+  @Test
+  public void testOutOfServiceNodesNotSelected() throws SCMException {
+    List<DatanodeDetails> datanodeDetails =
+        policy.chooseDatanodes(null, null, 1, 0, 0);
+    Assert.assertEquals(1, datanodeDetails.size());

Review comment:
       Not sure these 3 lines are helpful.  Would you give a little more explanation? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org