You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2022/01/05 12:15:08 UTC
[lucenenet] 02/02: Directory.Build.targets: Added private NuGet dependency on Microsoft.NETFramework.ReferenceAssemblies, which removes the prerequisite of .NET Framework 4.8 Developer Pack to run builds.
This is an automated email from the ASF dual-hosted git repository.
nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git
commit 0a2c266385416b08fbf784010affc4aa9df72d14
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Tue Jan 4 04:33:58 2022 +0700
Directory.Build.targets: Added private NuGet dependency on Microsoft.NETFramework.ReferenceAssemblies, which removes the prerequisite of .NET Framework 4.8 Developer Pack to run builds.
---
Directory.Build.targets | 5 +++++
README.md | 4 +---
build/Dependencies.props | 1 +
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Directory.Build.targets b/Directory.Build.targets
index a436d23..82257b9 100644
--- a/Directory.Build.targets
+++ b/Directory.Build.targets
@@ -138,6 +138,11 @@
</Target>
<!-- Global PackageReferences -->
+ <ItemGroup>
+ <!-- This is to allow the .NET Framework references to be machine-indepenedent so builds can happen without installing prerequisites -->
+ <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="$(MicrosoftNETFrameworkReferenceAssembliesPackageReferenceVersion)" PrivateAssets="All" />
+ </ItemGroup>
+
<!-- This is for testing only, we use SourceLink from any Azure DevOps git repo -->
<ItemGroup Condition=" '$(BUILD_REPOSITORY_PROVIDER)' == 'TfsGit' " Label="SourceLink Packages (experimental Azure Repos)">
<PackageReference Include="Microsoft.SourceLink.AzureRepos.Git" Version="$(MicrosoftSourceLinkAzureReposGitPackageReferenceVersion)" PrivateAssets="All"/>
diff --git a/README.md b/README.md
index ed5b182..7136aef 100644
--- a/README.md
+++ b/README.md
@@ -177,7 +177,6 @@ Building on the Command Line is currently only supported on Windows.
1. [Powershell](https://msdn.microsoft.com/en-us/powershell/scripting/setup/installing-windows-powershell) 3.0 or higher (see [this question](http://stackoverflow.com/questions/1825585/determine-installed-powershell-version) to check your Powershell version)
2. [.NET 6.0 SDK or higher](https://dotnet.microsoft.com/download/visual-studio-sdks)
-3. [.NET Framework 4.8 Developer Pack](https://dotnet.microsoft.com/download/visual-studio-sdks)
##### Execution
@@ -257,9 +256,8 @@ Then all you need to do is choose the `Lucene.Net Local Packages` feed from the
1. Visual Studio 2019 or higher
2. [.NET 6.0 SDK or higher](https://dotnet.microsoft.com/download/visual-studio-sdks)
-3. [.NET Framework 4.8 Developer Pack](https://dotnet.microsoft.com/download/visual-studio-sdks)
-> **NOTE:** Preview versions of .NET SDK may require the "Use previews of the .NET SDK (requires restart)" option to be enabled in Visual Studio under Tools > Options > Environment > Preview Features.
+> **NOTE:** Preview versions of .NET SDK require the "Use previews of the .NET SDK (requires restart)" option to be enabled in Visual Studio under Tools > Options > Environment > Preview Features. .NET 6.0 is not supported on Visual Studio 2019, so the only option available for building on VS 2019 is to use a pre-release .NET 6.0 SDK.
#### Execution
diff --git a/build/Dependencies.props b/build/Dependencies.props
index 819cfd6..96f5315 100644
--- a/build/Dependencies.props
+++ b/build/Dependencies.props
@@ -59,6 +59,7 @@
<MicrosoftExtensionsDependencyInjectionAbstractionsPackageVersion>2.0.0</MicrosoftExtensionsDependencyInjectionAbstractionsPackageVersion>
<MicrosoftExtensionsDependencyInjectionPackageVersion>$(MicrosoftExtensionsDependencyInjectionAbstractionsPackageVersion)</MicrosoftExtensionsDependencyInjectionPackageVersion>
<MicrosoftExtensionsOptionsPackageVersion>2.0.0</MicrosoftExtensionsOptionsPackageVersion>
+ <MicrosoftNETFrameworkReferenceAssembliesPackageReferenceVersion>1.0.2</MicrosoftNETFrameworkReferenceAssembliesPackageReferenceVersion>
<MicrosoftNETTestSdkPackageVersion>16.6.1</MicrosoftNETTestSdkPackageVersion>
<MicrosoftSourceLinkAzureReposGitPackageReferenceVersion>1.1.1</MicrosoftSourceLinkAzureReposGitPackageReferenceVersion>
<MicrosoftSourceLinkGitHubPackageReferenceVersion>$(MicrosoftSourceLinkAzureReposGitPackageReferenceVersion)</MicrosoftSourceLinkGitHubPackageReferenceVersion>