You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by ro...@apache.org on 2013/06/29 14:52:13 UTC

git commit: THRIFT-2074 cppcheck error removed from ThreadManager.cpp Patch: Konrad Grochowski

Updated Branches:
  refs/heads/master c36b56d3d -> ffbfd03cc


THRIFT-2074 cppcheck error removed from ThreadManager.cpp
Patch: Konrad Grochowski


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/ffbfd03c
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/ffbfd03c
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/ffbfd03c

Branch: refs/heads/master
Commit: ffbfd03cc2a943a41b28e82dafd3d4c7438cf04c
Parents: c36b56d
Author: Roger Meier <ro...@apache.org>
Authored: Sat Jun 29 14:51:30 2013 +0200
Committer: Roger Meier <ro...@apache.org>
Committed: Sat Jun 29 14:51:30 2013 +0200

----------------------------------------------------------------------
 lib/cpp/src/thrift/concurrency/ThreadManager.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/ffbfd03c/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
----------------------------------------------------------------------
diff --git a/lib/cpp/src/thrift/concurrency/ThreadManager.cpp b/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
index 298dbac..f2c0fa5 100644
--- a/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
+++ b/lib/cpp/src/thrift/concurrency/ThreadManager.cpp
@@ -446,8 +446,8 @@ void ThreadManager::Impl::removeWorker(size_t value) {
     }
 
     for (std::set<shared_ptr<Thread> >::iterator ix = deadWorkers_.begin(); ix != deadWorkers_.end(); ix++) {
-      workers_.erase(*ix);
       idMap_.erase((*ix)->getId());
+      workers_.erase(*ix);
     }
 
     deadWorkers_.clear();