You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/06 01:48:52 UTC

[GitHub] [apisix] tokers commented on a change in pull request #4183: feat(ext-plugin): implement the http-req-call protocol

tokers commented on a change in pull request #4183:
URL: https://github.com/apache/apisix/pull/4183#discussion_r627021898



##########
File path: apisix/plugins/ext-plugin/init.lua
##########
@@ -152,6 +165,80 @@ end
 _M.receive = receive
 
 
+local generate_id
+do
+    local count = 0
+    local MAX_COUNT = lshift(1, 22)
+
+    function generate_id()
+        local wid = worker_id()
+        local id = lshift(wid, 22) + count
+        count = count + 1
+        if count == MAX_COUNT then
+            count = 0

Review comment:
       Does the id rotate will influence the correctness?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org