You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sb...@pivotal.io> on 2016/02/17 22:29:10 UTC
GEODE-52 Remove @author tags from Java source
In preparation towards graduation I am planning to remove author tags from
all source files.
GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
discussions whether we should or shouldn`t remove them.
I would like to restart the discussion and get a fresh consensus from the
community.
Find below some of the reasons why ASF is against the author tags:
- Attributions in source files are not up to date.
- Software is a team effort.
- ASF sells the code base as an ASF brand.
- Shield against law-suits.
--
Sai Boorlagadda
Re: GEODE-52 Remove @author tags from Java source
Posted by Dan Smith <ds...@pivotal.io>.
+1
-Dan
On Wed, Feb 17, 2016 at 1:35 PM, Anthony Baker <ab...@pivotal.io> wrote:
> +1
>
> The ASF policy is well known [1] and I think @author information is no
> longer helpful in any case.
>
> Anthony
>
> [1]
> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
>
> > On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io>
> wrote:
> >
> > In preparation towards graduation I am planning to remove author tags
> from
> > all source files.
> >
> > GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
> > discussions whether we should or shouldn`t remove them.
> >
> > I would like to restart the discussion and get a fresh consensus from the
> > community.
> >
> > Find below some of the reasons why ASF is against the author tags:
> >
> > - Attributions in source files are not up to date.
> > - Software is a team effort.
> > - ASF sells the code base as an ASF brand.
> > - Shield against law-suits.
> >
> > --
> > Sai Boorlagadda
>
>
Re: GEODE-52 Remove @author tags from Java source
Posted by Sai Boorlagadda <sb...@pivotal.io>.
GEODE-52 is committed to develop.
Please note that you will see ~3.5K files modified in your next git pull.
Sai
On Fri, Mar 25, 2016 at 3:20 PM, Jens Deppe <jd...@pivotal.io> wrote:
> Arrgh caught out by the @author tag!!!
>
> It looks like SeparateClassloaderTestRunner is not being used, so it should
> just be deleted.
>
> --Jens
>
> On Fri, Mar 25, 2016 at 12:42 PM, Sai Boorlagadda <sboorlagadda@pivotal.io
> >
> wrote:
>
> > re-initiating discussion about removing @author tags.
> >
> > I have closed old PR #100
> > <https://github.com/apache/incubator-geode/pull/100> as it was before
> > re-naming the sub projects. A new feature/GEODE-52 branch has been
> created
> > and source is checked-in after removing the author tags and considering
> the
> > review comments from PR #100
> > <https://github.com/apache/incubator-geode/pull/100>
> >
> > I would like get current work on feature/GEODE-52 to be wrapped-up and
> > merge to develop and work on below pending items:
> >
> > 1) GEODE-1132: Add a rat task to check @author tags
> > 2) GEODE-1133: SeparateClassloaderTestRunner has to be re-implemented
> >
> > Please help reviewing the changes @ https://reviews.apache.org/r/44484/.
> >
> > Sai
> >
>
--
Sai Boorlagadda
Re: GEODE-52 Remove @author tags from Java source
Posted by Jens Deppe <jd...@pivotal.io>.
Arrgh caught out by the @author tag!!!
It looks like SeparateClassloaderTestRunner is not being used, so it should
just be deleted.
--Jens
On Fri, Mar 25, 2016 at 12:42 PM, Sai Boorlagadda <sb...@pivotal.io>
wrote:
> re-initiating discussion about removing @author tags.
>
> I have closed old PR #100
> <https://github.com/apache/incubator-geode/pull/100> as it was before
> re-naming the sub projects. A new feature/GEODE-52 branch has been created
> and source is checked-in after removing the author tags and considering the
> review comments from PR #100
> <https://github.com/apache/incubator-geode/pull/100>
>
> I would like get current work on feature/GEODE-52 to be wrapped-up and
> merge to develop and work on below pending items:
>
> 1) GEODE-1132: Add a rat task to check @author tags
> 2) GEODE-1133: SeparateClassloaderTestRunner has to be re-implemented
>
> Please help reviewing the changes @ https://reviews.apache.org/r/44484/.
>
> Sai
>
Re: GEODE-52 Remove @author tags from Java source
Posted by Sai Boorlagadda <sb...@pivotal.io>.
re-initiating discussion about removing @author tags.
I have closed old PR #100
<https://github.com/apache/incubator-geode/pull/100> as it was before
re-naming the sub projects. A new feature/GEODE-52 branch has been created
and source is checked-in after removing the author tags and considering the
review comments from PR #100
<https://github.com/apache/incubator-geode/pull/100>
I would like get current work on feature/GEODE-52 to be wrapped-up and
merge to develop and work on below pending items:
1) GEODE-1132: Add a rat task to check @author tags
2) GEODE-1133: SeparateClassloaderTestRunner has to be re-implemented
Please help reviewing the changes @ https://reviews.apache.org/r/44484/.
Sai
Re: GEODE-52 Remove @author tags from Java source
Posted by Sai Boorlagadda <sb...@pivotal.io>.
Thanks everyone for upvoting this change.
I have removed @author tags from 3519 (Java + JS files) using 'find . -type
f -print0 | xargs -0 sed -i /@author/d'
Created a pull request #100
<https://github.com/apache/incubator-geode/pull/100>
Yay! 100th pull request on Geode.
Sai
On Thu, Feb 18, 2016 at 9:26 AM, Bruce Schuchardt <bs...@pivotal.io>
wrote:
> +1
>
> Author tags haven't been useful for a quite a while now
>
>
> Le 2/17/2016 1:35 PM, Anthony Baker a écrit :
>
>> +1
>>
>> The ASF policy is well known [1] and I think @author information is no
>> longer helpful in any case.
>>
>> Anthony
>>
>> [1]
>> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
>>
>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io>
>>> wrote:
>>>
>>> In preparation towards graduation I am planning to remove author tags
>>> from
>>> all source files.
>>>
>>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
>>> discussions whether we should or shouldn`t remove them.
>>>
>>> I would like to restart the discussion and get a fresh consensus from the
>>> community.
>>>
>>> Find below some of the reasons why ASF is against the author tags:
>>>
>>> - Attributions in source files are not up to date.
>>> - Software is a team effort.
>>> - ASF sells the code base as an ASF brand.
>>> - Shield against law-suits.
>>>
>>> --
>>> Sai Boorlagadda
>>>
>>
>
--
Sai Boorlagadda
Re: GEODE-52 Remove @author tags from Java source
Posted by Bruce Schuchardt <bs...@pivotal.io>.
+1
Author tags haven't been useful for a quite a while now
Le 2/17/2016 1:35 PM, Anthony Baker a écrit :
> +1
>
> The ASF policy is well known [1] and I think @author information is no longer helpful in any case.
>
> Anthony
>
> [1] http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
>
>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io> wrote:
>>
>> In preparation towards graduation I am planning to remove author tags from
>> all source files.
>>
>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
>> discussions whether we should or shouldn`t remove them.
>>
>> I would like to restart the discussion and get a fresh consensus from the
>> community.
>>
>> Find below some of the reasons why ASF is against the author tags:
>>
>> - Attributions in source files are not up to date.
>> - Software is a team effort.
>> - ASF sells the code base as an ASF brand.
>> - Shield against law-suits.
>>
>> --
>> Sai Boorlagadda
Re: GEODE-52 Remove @author tags from Java source
Posted by Jens Deppe <jd...@pivotal.io>.
+1
More accurately, the information is still maintained in source control.
Do you feel lucky? Do ya....?
find . -name '*.java' -type f | xargs perl -n -i -e 'print unless
m!^\s*\*\s*@author!'
On Wed, Feb 17, 2016 at 2:52 PM, Mark Bretl <as...@gmail.com> wrote:
> +1
>
> --Mark
>
> On Wed, Feb 17, 2016 at 2:01 PM, Jianxia Chen <jc...@pivotal.io> wrote:
>
> > +1
> >
> > On Wed, Feb 17, 2016 at 1:52 PM, William Markito <wm...@pivotal.io>
> > wrote:
> >
> > > +1
> > >
> > > Sent from my iPhone
> > >
> > > > On Feb 17, 2016, at 1:44 PM, Kenneth Howe <kh...@pivotal.io> wrote:
> > > >
> > > > +1
> > > >
> > > > Ken
> > > >
> > > >> On Feb 17, 2016, at 1:35 PM, Anthony Baker <ab...@pivotal.io>
> wrote:
> > > >>
> > > >> +1
> > > >>
> > > >> The ASF policy is well known [1] and I think @author information is
> no
> > > longer helpful in any case.
> > > >>
> > > >> Anthony
> > > >>
> > > >> [1]
> > >
> >
> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
> > > >>
> > > >>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <
> > sboorlagadda@pivotal.io>
> > > wrote:
> > > >>>
> > > >>> In preparation towards graduation I am planning to remove author
> tags
> > > from
> > > >>> all source files.
> > > >>>
> > > >>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has
> some
> > > >>> discussions whether we should or shouldn`t remove them.
> > > >>>
> > > >>> I would like to restart the discussion and get a fresh consensus
> from
> > > the
> > > >>> community.
> > > >>>
> > > >>> Find below some of the reasons why ASF is against the author tags:
> > > >>>
> > > >>> - Attributions in source files are not up to date.
> > > >>> - Software is a team effort.
> > > >>> - ASF sells the code base as an ASF brand.
> > > >>> - Shield against law-suits.
> > > >>>
> > > >>> --
> > > >>> Sai Boorlagadda
> > > >
> > >
> >
>
Re: GEODE-52 Remove @author tags from Java source
Posted by Mark Bretl <as...@gmail.com>.
+1
--Mark
On Wed, Feb 17, 2016 at 2:01 PM, Jianxia Chen <jc...@pivotal.io> wrote:
> +1
>
> On Wed, Feb 17, 2016 at 1:52 PM, William Markito <wm...@pivotal.io>
> wrote:
>
> > +1
> >
> > Sent from my iPhone
> >
> > > On Feb 17, 2016, at 1:44 PM, Kenneth Howe <kh...@pivotal.io> wrote:
> > >
> > > +1
> > >
> > > Ken
> > >
> > >> On Feb 17, 2016, at 1:35 PM, Anthony Baker <ab...@pivotal.io> wrote:
> > >>
> > >> +1
> > >>
> > >> The ASF policy is well known [1] and I think @author information is no
> > longer helpful in any case.
> > >>
> > >> Anthony
> > >>
> > >> [1]
> >
> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
> > >>
> > >>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <
> sboorlagadda@pivotal.io>
> > wrote:
> > >>>
> > >>> In preparation towards graduation I am planning to remove author tags
> > from
> > >>> all source files.
> > >>>
> > >>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
> > >>> discussions whether we should or shouldn`t remove them.
> > >>>
> > >>> I would like to restart the discussion and get a fresh consensus from
> > the
> > >>> community.
> > >>>
> > >>> Find below some of the reasons why ASF is against the author tags:
> > >>>
> > >>> - Attributions in source files are not up to date.
> > >>> - Software is a team effort.
> > >>> - ASF sells the code base as an ASF brand.
> > >>> - Shield against law-suits.
> > >>>
> > >>> --
> > >>> Sai Boorlagadda
> > >
> >
>
Re: GEODE-52 Remove @author tags from Java source
Posted by Jianxia Chen <jc...@pivotal.io>.
+1
On Wed, Feb 17, 2016 at 1:52 PM, William Markito <wm...@pivotal.io>
wrote:
> +1
>
> Sent from my iPhone
>
> > On Feb 17, 2016, at 1:44 PM, Kenneth Howe <kh...@pivotal.io> wrote:
> >
> > +1
> >
> > Ken
> >
> >> On Feb 17, 2016, at 1:35 PM, Anthony Baker <ab...@pivotal.io> wrote:
> >>
> >> +1
> >>
> >> The ASF policy is well known [1] and I think @author information is no
> longer helpful in any case.
> >>
> >> Anthony
> >>
> >> [1]
> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
> >>
> >>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io>
> wrote:
> >>>
> >>> In preparation towards graduation I am planning to remove author tags
> from
> >>> all source files.
> >>>
> >>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
> >>> discussions whether we should or shouldn`t remove them.
> >>>
> >>> I would like to restart the discussion and get a fresh consensus from
> the
> >>> community.
> >>>
> >>> Find below some of the reasons why ASF is against the author tags:
> >>>
> >>> - Attributions in source files are not up to date.
> >>> - Software is a team effort.
> >>> - ASF sells the code base as an ASF brand.
> >>> - Shield against law-suits.
> >>>
> >>> --
> >>> Sai Boorlagadda
> >
>
Re: GEODE-52 Remove @author tags from Java source
Posted by Vincent Ford <vf...@pivotal.io>.
+1
*Vince Ford*
GemFire Sustenance Engineering
Beaverton, OR USA
http://www.pivotal.io
Open Source Project Geode https://geode.incubator.apache.org/
<https://network.pivotal.io/products/project-geode>
On Wed, Feb 17, 2016 at 1:52 PM, William Markito <wm...@pivotal.io>
wrote:
> +1
>
> Sent from my iPhone
>
> > On Feb 17, 2016, at 1:44 PM, Kenneth Howe <kh...@pivotal.io> wrote:
> >
> > +1
> >
> > Ken
> >
> >> On Feb 17, 2016, at 1:35 PM, Anthony Baker <ab...@pivotal.io> wrote:
> >>
> >> +1
> >>
> >> The ASF policy is well known [1] and I think @author information is no
> longer helpful in any case.
> >>
> >> Anthony
> >>
> >> [1]
> http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
> >>
> >>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io>
> wrote:
> >>>
> >>> In preparation towards graduation I am planning to remove author tags
> from
> >>> all source files.
> >>>
> >>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
> >>> discussions whether we should or shouldn`t remove them.
> >>>
> >>> I would like to restart the discussion and get a fresh consensus from
> the
> >>> community.
> >>>
> >>> Find below some of the reasons why ASF is against the author tags:
> >>>
> >>> - Attributions in source files are not up to date.
> >>> - Software is a team effort.
> >>> - ASF sells the code base as an ASF brand.
> >>> - Shield against law-suits.
> >>>
> >>> --
> >>> Sai Boorlagadda
> >
>
Re: GEODE-52 Remove @author tags from Java source
Posted by William Markito <wm...@pivotal.io>.
+1
Sent from my iPhone
> On Feb 17, 2016, at 1:44 PM, Kenneth Howe <kh...@pivotal.io> wrote:
>
> +1
>
> Ken
>
>> On Feb 17, 2016, at 1:35 PM, Anthony Baker <ab...@pivotal.io> wrote:
>>
>> +1
>>
>> The ASF policy is well known [1] and I think @author information is no longer helpful in any case.
>>
>> Anthony
>>
>> [1] http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
>>
>>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io> wrote:
>>>
>>> In preparation towards graduation I am planning to remove author tags from
>>> all source files.
>>>
>>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
>>> discussions whether we should or shouldn`t remove them.
>>>
>>> I would like to restart the discussion and get a fresh consensus from the
>>> community.
>>>
>>> Find below some of the reasons why ASF is against the author tags:
>>>
>>> - Attributions in source files are not up to date.
>>> - Software is a team effort.
>>> - ASF sells the code base as an ASF brand.
>>> - Shield against law-suits.
>>>
>>> --
>>> Sai Boorlagadda
>
Re: GEODE-52 Remove @author tags from Java source
Posted by Kenneth Howe <kh...@pivotal.io>.
+1
Ken
> On Feb 17, 2016, at 1:35 PM, Anthony Baker <ab...@pivotal.io> wrote:
>
> +1
>
> The ASF policy is well known [1] and I think @author information is no longer helpful in any case.
>
> Anthony
>
> [1] http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
>
>> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io> wrote:
>>
>> In preparation towards graduation I am planning to remove author tags from
>> all source files.
>>
>> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
>> discussions whether we should or shouldn`t remove them.
>>
>> I would like to restart the discussion and get a fresh consensus from the
>> community.
>>
>> Find below some of the reasons why ASF is against the author tags:
>>
>> - Attributions in source files are not up to date.
>> - Software is a team effort.
>> - ASF sells the code base as an ASF brand.
>> - Shield against law-suits.
>>
>> --
>> Sai Boorlagadda
>
Re: GEODE-52 Remove @author tags from Java source
Posted by Anthony Baker <ab...@pivotal.io>.
+1
The ASF policy is well known [1] and I think @author information is no longer helpful in any case.
Anthony
[1] http://www.apache.org/foundation/records/minutes/2004/board_minutes_2004_02_18.txt
> On Feb 17, 2016, at 1:29 PM, Sai Boorlagadda <sb...@pivotal.io> wrote:
>
> In preparation towards graduation I am planning to remove author tags from
> all source files.
>
> GEODE-52 <https://issues.apache.org/jira/browse/GEODE-52>, has some
> discussions whether we should or shouldn`t remove them.
>
> I would like to restart the discussion and get a fresh consensus from the
> community.
>
> Find below some of the reasons why ASF is against the author tags:
>
> - Attributions in source files are not up to date.
> - Software is a team effort.
> - ASF sells the code base as an ASF brand.
> - Shield against law-suits.
>
> --
> Sai Boorlagadda