You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/11/26 15:40:13 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #4902: esp32xx_rtc.c: Fix a duplicated assignment.
Ouss4 opened a new pull request #4902:
URL: https://github.com/apache/incubator-nuttx/pull/4902
## Summary
esp32xx_rtc.c: Fix a duplicated assignment.
## Impact
ESP32 and ESP32-C3 RTC driver
## Testing
esp32-devkitc:rtc
esp32c3-devkit:rtc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4902: esp32xx_rtc.c: misc. fixes.
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #4902:
URL: https://github.com/apache/incubator-nuttx/pull/4902#discussion_r757653386
##########
File path: arch/risc-v/src/esp32c3/esp32c3_rtc.c
##########
@@ -2464,8 +2467,8 @@ int up_rtc_gettime(struct timespec *tp)
}
else
{
- time_us = = esp32c3_rtc_get_time_us() +
- esp32c3_rtc_get_boot_time();
+ time_us = esp32c3_rtc_get_time_us() +
+ esp32c3_rtc_get_boot_time();
Review comment:
```suggestion
time_us = esp32c3_rtc_get_time_us() + esp32c3_rtc_get_boot_time();
```
nit: These lines fit in a single one, how about merging them?
##########
File path: arch/xtensa/src/esp32/esp32_rtc.c
##########
@@ -2066,8 +2069,8 @@ int up_rtc_gettime(struct timespec *tp)
}
else
{
- time_us = = esp32_rtc_get_time_us() +
- esp32_rtc_get_boot_time();
+ time_us = esp32_rtc_get_time_us() +
+ esp32_rtc_get_boot_time();
Review comment:
```suggestion
time_us = esp32_rtc_get_time_us() + esp32_rtc_get_boot_time();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #4902: esp32xx_rtc.c: misc. fixes.
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #4902:
URL: https://github.com/apache/incubator-nuttx/pull/4902#discussion_r757655011
##########
File path: arch/risc-v/src/esp32c3/esp32c3_rtc.c
##########
@@ -2464,8 +2467,8 @@ int up_rtc_gettime(struct timespec *tp)
}
else
{
- time_us = = esp32c3_rtc_get_time_us() +
- esp32c3_rtc_get_boot_time();
+ time_us = esp32c3_rtc_get_time_us() +
+ esp32c3_rtc_get_boot_time();
Review comment:
Thanks fixed.
##########
File path: arch/xtensa/src/esp32/esp32_rtc.c
##########
@@ -2066,8 +2069,8 @@ int up_rtc_gettime(struct timespec *tp)
}
else
{
- time_us = = esp32_rtc_get_time_us() +
- esp32_rtc_get_boot_time();
+ time_us = esp32_rtc_get_time_us() +
+ esp32_rtc_get_boot_time();
Review comment:
Done. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] gustavonihei merged pull request #4902: esp32xx_rtc.c: misc. fixes.
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #4902:
URL: https://github.com/apache/incubator-nuttx/pull/4902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org