[GitHub] [shardingsphere] pk-218 commented on pull request #15803: Add unit test for PipelineTableMetaData

[GitBox <gi...@apache.org>]

pk-218 commented on pull request #15803:
URL: https://github.com/apache/shardingsphere/pull/15803#issuecomment-1059771019


   @sandynz I ran the tests again and I have 2 errors, both occur while passing `columnIndex = 0`
   ```java
   PipelineColumnMetaData actual = pipelineTableMetaData.getColumnMetaData(0);
   assertTrue(pipelineTableMetaData.isPrimaryKey(0));
   ```
   
   This is the log obtained on running the tests.
   ```
   [ERROR] Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.002 s <<< FAILURE! - in org.apache.shardingsphere.data.pipeline.core.metadata.model
   .PipelineTableMetaDataTest
   [ERROR] assertGetColumnMetaDataGivenColumnIndex(org.apache.shardingsphere.data.pipeline.core.metadata.model.PipelineTableMetaDataTest)  Time elapsed: 0.002 s
     <<< ERROR!
   java.lang.NullPointerException
           at org.apache.shardingsphere.data.pipeline.core.metadata.model.PipelineTableMetaDataTest.assertGetColumnMetaDataGivenColumnIndex(PipelineTableMetaDat
   aTest.java:44)
   
   [ERROR] assertIsPrimaryKey(org.apache.shardingsphere.data.pipeline.core.metadata.model.PipelineTableMetaDataTest)  Time elapsed: 0 s  <<< ERROR!
   java.lang.NullPointerException
           at org.apache.shardingsphere.data.pipeline.core.metadata.model.PipelineTableMetaDataTest.assertIsPrimaryKey(PipelineTableMetaDataTest.java:59)
   ```
   
   
   Could you please review why these errors are occurring? Or should I first push the code with new changes for review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org