You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/04 07:52:49 UTC

[GitHub] [mynewt-core] kasjer commented on pull request #2463: hw/mcu/da1469x: Fix HAL UART creation

kasjer commented on pull request #2463:
URL: https://github.com/apache/mynewt-core/pull/2463#issuecomment-773107660


   > @kasjer LGTM. I tested with `HAL_UART: 1` and all works. There is a CI failure (style?). I approved but I'll wait for someone else to review the CI failure before merging.
   
   @benmccrea Right now CI fails due to missing linker script **stm32l073.ld** which has nothing to do with this PR. This happened while CI was not really working for a while. Pending #2468 addresses this problem.
   So I think we can merge this one.
   Tanks for testing it out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org