You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "317brian (via GitHub)" <gi...@apache.org> on 2024/05/15 22:58:26 UTC

[PR] docs: msq index page update (druid)

317brian opened a new pull request, #16459:
URL: https://github.com/apache/druid/pull/16459

   Seems like MSQ is enabled by default now, and we missed updating this line when the change happened. 
   
   Also the extern bit seems out of place down there. I think it was an accident for it to go there? I moved it next to the info about functions 
   This PR has:
   
   - [x] been self-reviewed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] docs: msq index page update (druid)

Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe commented on code in PR #16459:
URL: https://github.com/apache/druid/pull/16459#discussion_r1623182509


##########
docs/multi-stage-query/index.md:
##########
@@ -30,7 +30,7 @@ description: Introduces multi-stage query architecture and its task engine
  ingestion method is right for you.
 :::
 
-Apache Druid supports SQL-based ingestion using the bundled [`druid-multi-stage-query` extension](#load-the-extension).
+Apache Druid supports SQL-based ingestion using the bundled `druid-multi-stage-query` extension, which is enabled by default.

Review Comment:
   What does enabled by default mean here. 
   The extension is part of the example configs. Is that the definition of default here ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] docs: msq index page update (druid)

Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian commented on code in PR #16459:
URL: https://github.com/apache/druid/pull/16459#discussion_r1624882049


##########
docs/multi-stage-query/index.md:
##########
@@ -30,7 +30,7 @@ description: Introduces multi-stage query architecture and its task engine
  ingestion method is right for you.
 :::
 
-Apache Druid supports SQL-based ingestion using the bundled [`druid-multi-stage-query` extension](#load-the-extension).
+Apache Druid supports SQL-based ingestion using the bundled `druid-multi-stage-query` extension, which is enabled by default.

Review Comment:
   Do people generally use the example configs for production deployments?
   
   Maybe this instead:
   
   ```suggestion
   Apache Druid supports SQL-based ingestion using the bundled `druid-multi-stage-query` extension, which is loaded by default in the example configs if you use `./bin/start-druid` to launch Druid.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] docs: msq index page update (druid)

Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian commented on PR #16459:
URL: https://github.com/apache/druid/pull/16459#issuecomment-2137946945

   ping. @cryptoe @kfaraz 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] docs: msq index page update (druid)

Posted by "317brian (via GitHub)" <gi...@apache.org>.
317brian closed pull request #16459: docs: msq index page update
URL: https://github.com/apache/druid/pull/16459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org