[jira] [Commented] (HDFS-3024) Improve performance of stringification in addStoredBlock

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13217970#comment-13217970 ] 

Hadoop QA commented on HDFS-3024:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12516283/hdfs-3024.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.server.datanode.TestMulitipleNNDataBlockScanner

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1916//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1916//console

This message is automatically generated.
                
> Improve performance of stringification in addStoredBlock
> --------------------------------------------------------
>
>                 Key: HDFS-3024
>                 URL: https://issues.apache.org/jira/browse/HDFS-3024
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3024.txt
>
>
> In looking at stack traces of a NN under a heavy block allocation load (around a thousand per second) I see that a lot of time is being taken up in stringification of log messages for addStoredBlock. This code can be optimized to use a single StringBuilder instead of a lot of nested toString() calls.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira