You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "cmcfarlen (via GitHub)" <gi...@apache.org> on 2023/10/02 21:40:56 UTC

[PR] cmake: Support external yaml-cpp [trafficserver]

cmcfarlen opened a new pull request, #10554:
URL: https://github.com/apache/trafficserver/pull/10554

   This adds support for using external yaml-cpp library.
   
   You can use this like so:
   ```
   cmake . -B build -DEXTERNAL_YAML_CPP -Dyaml-cpp_ROOT=/opt/yaml
   ```
   
   The caveat is we require 0.8.0 since that is what ATS expects and prior versions of yaml-cpp don't expose the same cmake targets.  Further, using newer versions is risky since yaml-cpp declares `AnyNewerVersion` for compatibility which could be just a giant lie.  We currently use the latest version, so this is a problem for the future.
   
   As a side-effect, this PR also cleans up some link_libraries calls due to removing the global includes for libswoc and yaml-cpp.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cmake: Support external yaml-cpp [trafficserver]

Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #10554:
URL: https://github.com/apache/trafficserver/pull/10554#issuecomment-1743847470

   https://ci.trafficserver.apache.org/job/Github_Builds/job/cmake/1719/console
   
   ```
   Total Test time (real) =  34.38 sec
   + /tmp/ats/bin/traffic_server -K -k -R 1
   /tmp/ats/bin/traffic_server: error while loading shared libraries: libyaml-cppd.so.0.8: cannot open shared object file: No such file or directory
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cmake: Support external yaml-cpp [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #10554:
URL: https://github.com/apache/trafficserver/pull/10554


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] cmake: Support external yaml-cpp [trafficserver]

Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #10554:
URL: https://github.com/apache/trafficserver/pull/10554#discussion_r1343206993


##########
lib/swoc/CMakeLists.txt:
##########
@@ -7,6 +7,7 @@ cmake_policy(SET CMP0087 NEW)
 # override "lib64" to be "lib" unless the user explicitly sets it.
 set(CMAKE_INSTALL_LIBDIR "lib" CACHE STRING "directory for libraries" FORCE)
 include(GNUInstallDirs)
+include(CMakeDependentOption)

Review Comment:
   This is already fixed in upstream libswoc so should be fine after updating



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org