You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/07/09 07:40:02 UTC
[GitHub] codecov-io edited a comment on issue #2049: [dubbo-2029]: upgrade
netty4 to the latest release and make it the default option for transporter
codecov-io edited a comment on issue #2049: [dubbo-2029]: upgrade netty4 to the latest release and make it the default option for transporter
URL: https://github.com/apache/incubator-dubbo/pull/2049#issuecomment-403354348
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2049?src=pr&el=h1) Report
> Merging [#2049](https://codecov.io/gh/apache/incubator-dubbo/pull/2049?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/b36a6eea627f9854c909b3a9368ddb06fc6610e4?src=pr&el=desc) will **increase** coverage by `0.83%`.
> The diff coverage is `12.5%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2049?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2049 +/- ##
============================================
+ Coverage 52.19% 53.02% +0.83%
- Complexity 4963 4986 +23
============================================
Files 568 568
Lines 25453 25460 +7
Branches 4486 4487 +1
============================================
+ Hits 13285 13501 +216
+ Misses 10144 9913 -231
- Partials 2024 2046 +22
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2049?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...bbo/remoting/transport/netty/NettyTransporter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVRyYW5zcG9ydGVyLmphdmE=) | `100% <ø> (ø)` | `3 <0> (ø)` | :arrow_down: |
| [...bo/remoting/transport/netty4/NettyTransporter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5VHJhbnNwb3J0ZXIuamF2YQ==) | `100% <ø> (ø)` | `3 <0> (ø)` | :arrow_down: |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `58.33% <12.5%> (-14.09%)` | `5 <0> (ø)` | |
| [...ache/dubbo/remoting/p2p/support/AbstractGroup.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctcDJwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy9wMnAvc3VwcG9ydC9BYnN0cmFjdEdyb3VwLmphdmE=) | `45.45% <0%> (-11.37%)` | `7% <0%> (-1%)` | |
| [...he/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNsaWVudC5qYXZh) | `72.88% <0%> (-8.48%)` | `12% <0%> (-1%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9JbnZva2VUZWxuZXRIYW5kbGVyLmphdmE=) | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
| [...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NhbGxiYWNrU2VydmljZUNvZGVjLmphdmE=) | `77.2% <0%> (-1.48%)` | `29% <0%> (ø)` | |
| [.../dubbo/remoting/transport/netty4/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2hhbm5lbC5qYXZh) | `65% <0%> (-1.25%)` | `22% <0%> (-1%)` | |
| [.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1pbmp2bS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2luanZtL0luanZtSW52b2tlci5qYXZh) | `69.23% <0%> (+15.38%)` | `3% <0%> (+1%)` | :arrow_up: |
| [.../apache/dubbo/rpc/protocol/thrift/ThriftUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90aHJpZnQvVGhyaWZ0VXRpbHMuamF2YQ==) | `91.8% <0%> (+16.39%)` | `8% <0%> (+2%)` | :arrow_up: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2049/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2049?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2049?src=pr&el=footer). Last update [b36a6ee...7f89783](https://codecov.io/gh/apache/incubator-dubbo/pull/2049?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org