You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/01/21 21:29:02 UTC

Review Request 30136: Fix post-install hook for hdp-select

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.


Bugs: AMBARI-9248
    https://issues.apache.org/jira/browse/AMBARI-9248


Repository: ambari


Description
-------

There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 

Diff: https://reviews.apache.org/r/30136/diff/


Testing
-------

Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.865s]
[INFO] Ambari Server ..................................... SUCCESS [35.053s]
[INFO] Ambari Agent ...................................... SUCCESS [6.128s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44.924s
[INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
[INFO] Final Memory: 41M/353M


Thanks,

Dmitro Lisnichenko


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Jan. 21, 2015, 9:30 p.m., Nate Cole wrote:
> > ambari-agent/src/main/python/ambari_agent/HostCleanup.py, line 93
> > <https://reviews.apache.org/r/30136/diff/3/?file=828835#file828835line93>
> >
> >     Probably should calculate this out of ambari-agent.ini.  The agent section has a key, "prefix" that can be used.

Stack scripts have no direct access to ambari-agent.ini. Moreover, ini file parsing is built into ambari-agent code. I think it would be an overkill


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review69016
-----------------------------------------------------------


On Jan. 21, 2015, 9:18 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Jan. 21, 2015, 9:30 p.m., Nate Cole wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py, lines 27-30
> > <https://reviews.apache.org/r/30136/diff/3/?file=828837#file828837line27>
> >
> >     Any tests that exercise this code that need to be taken care of?

patch does not break existing tests


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review69016
-----------------------------------------------------------


On Jan. 21, 2015, 9:18 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review69016
-----------------------------------------------------------

Ship it!



ambari-agent/src/main/python/ambari_agent/HostCleanup.py
<https://reviews.apache.org/r/30136/#comment113587>

    Probably should calculate this out of ambari-agent.ini.  The agent section has a key, "prefix" that can be used.



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
<https://reviews.apache.org/r/30136/#comment113588>

    Any tests that exercise this code that need to be taken care of?


- Nate Cole


On Jan. 21, 2015, 4:18 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 4:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review69018
-----------------------------------------------------------

Ship it!


Ship It!

- Tom Beerbower


On Jan. 21, 2015, 9:18 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 9:18 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.


Changes
-------

The correct patch
Added file removal during host cleanup. Verified manually + unit test


Bugs: AMBARI-9248
    https://issues.apache.org/jira/browse/AMBARI-9248


Repository: ambari


Description
-------

There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
  ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 

Diff: https://reviews.apache.org/r/30136/diff/


Testing
-------

Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.865s]
[INFO] Ambari Server ..................................... SUCCESS [35.053s]
[INFO] Ambari Agent ...................................... SUCCESS [6.128s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44.924s
[INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
[INFO] Final Memory: 41M/353M


Thanks,

Dmitro Lisnichenko


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review69010
-----------------------------------------------------------


Wrong diff..

- Dmitro Lisnichenko


On Jan. 21, 2015, 9:16 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 9:16 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java dd18e8d 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 6620577 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStageContainer.java 49ba946 
>   ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/kerberos.json 6ab7610 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
>   ambari-server/src/main/resources/stacks/HDP/2.2/kerberos.json 46aff38 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 6f2699b 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java a0e358a 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java c6c9574 
>   ambari-web/app/assets/test/tests.js 827ccb8 
>   ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js 29c8306 
>   ambari-web/app/controllers/main/host/details.js 40077f7 
>   ambari-web/app/models/service_config.js 047c1b2 
>   ambari-web/app/templates/main/admin/highAvailability/resourceManager/step3.hbs c143eef 
>   ambari-web/app/utils/config.js 6eaad57 
>   ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js 155bc67 
>   ambari-web/test/controllers/main/host/details_test.js 41b32ad 
>   ambari-web/test/models/service_config_test.js afdd663 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/
-----------------------------------------------------------

(Updated Jan. 21, 2015, 9:16 p.m.)


Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.


Changes
-------

Added file removal during host cleanup. Verified manually + unit test


Bugs: AMBARI-9248
    https://issues.apache.org/jira/browse/AMBARI-9248


Repository: ambari


Description
-------

There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
  ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java dd18e8d 
  ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 6620577 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStageContainer.java 49ba946 
  ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/kerberos.json 6ab7610 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
  ambari-server/src/main/resources/stacks/HDP/2.2/kerberos.json 46aff38 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java 6f2699b 
  ambari-server/src/test/java/org/apache/ambari/server/controller/BackgroundCustomCommandExecutionTest.java a0e358a 
  ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java c6c9574 
  ambari-web/app/assets/test/tests.js 827ccb8 
  ambari-web/app/controllers/main/admin/highAvailability/resourceManager/step3_controller.js 29c8306 
  ambari-web/app/controllers/main/host/details.js 40077f7 
  ambari-web/app/models/service_config.js 047c1b2 
  ambari-web/app/templates/main/admin/highAvailability/resourceManager/step3.hbs c143eef 
  ambari-web/app/utils/config.js 6eaad57 
  ambari-web/test/controllers/main/admin/highAvailability/resourceManager/step3_controller_test.js 155bc67 
  ambari-web/test/controllers/main/host/details_test.js 41b32ad 
  ambari-web/test/models/service_config_test.js afdd663 

Diff: https://reviews.apache.org/r/30136/diff/


Testing
-------

Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.865s]
[INFO] Ambari Server ..................................... SUCCESS [35.053s]
[INFO] Ambari Agent ...................................... SUCCESS [6.128s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 44.924s
[INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
[INFO] Final Memory: 41M/353M


Thanks,

Dmitro Lisnichenko


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

> On Jan. 21, 2015, 8:35 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py, line 24
> > <https://reviews.apache.org/r/30136/diff/1/?file=828777#file828777line24>
> >
> >     Does the host cleanup script need to delete this file?

Thank you for tip!


- Dmitro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review68998
-----------------------------------------------------------


On Jan. 21, 2015, 9:18 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 9:18 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7aeb70a 
>   ambari-agent/src/test/python/ambari_agent/TestHostCleanup.py 84b96cc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 30136: Fix post-install hook for hdp-select

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30136/#review68998
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
<https://reviews.apache.org/r/30136/#comment113573>

    Does the host cleanup script need to delete this file?


- Alejandro Fernandez


On Jan. 21, 2015, 8:29 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30136/
> -----------------------------------------------------------
> 
> (Updated Jan. 21, 2015, 8:29 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9248
>     https://issues.apache.org/jira/browse/AMBARI-9248
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> There's a post-install hook to perform hdp-select. This has erroneous logic and sets the /usr/hdp/current version to the latest installed
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py f256688 
> 
> Diff: https://reviews.apache.org/r/30136/diff/
> 
> 
> Testing
> -------
> 
> Short manual check to ensure that fix behaves as intended. Now conducting a full-pledged deployment to see all effects
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.865s]
> [INFO] Ambari Server ..................................... SUCCESS [35.053s]
> [INFO] Ambari Agent ...................................... SUCCESS [6.128s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 44.924s
> [INFO] Finished at: Wed Jan 21 23:27:12 FET 2015
> [INFO] Final Memory: 41M/353M
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>