[jira] [Commented] (SOLR-8454) Improve logging by ZkStateReader

["Anshum Gupta (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067732#comment-15067732 ] 

Anshum Gupta commented on SOLR-8454:
------------------------------------

Thanks for doing this. The usage of LOG vs log is kind of split in the code base and I don't have a strong opinion on that so that's ok.

I see you've capitalized log messages i.e. upper case starting char, at all places but here
{code}
LOG.debug("server older than client {}<{}", collection.getZNodeVersion(), version);
{code}

The rest all looks good to me to commit.

> Improve logging by ZkStateReader
> --------------------------------
>
>                 Key: SOLR-8454
>                 URL: https://issues.apache.org/jira/browse/SOLR-8454
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 5.5, Trunk
>
>         Attachments: SOLR-8454.patch
>
>
> Improve logging output by ZkStateReader, by adding the following:
> * Use LOG.foo() with parameters properly (i.e. not concatenating strings w/ +)
> * Surround parameters with [], to help readability, especially w/ empty values
> * Add missing string messages, where I felt a message will clarify
> * Convert some try-catch to a try-multicatch and improve output log message



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org