You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "helifu (Code Review)" <ge...@cloudera.org> on 2019/11/27 03:27:29 UTC
[kudu-CR] tserver: expose the number of round trips for a scanner
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14803
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
tserver: expose the number of round trips for a scanner
Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
---
M src/kudu/tserver/tserver_path_handlers.cc
M www/scans.mustache
2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/14803/1
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 1
Gerrit-Owner: helifu <hz...@corp.netease.com>
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14803 )
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
Patch Set 3: Code-Review+2
> Sure.
> https://slack-files.com/T0CPU21PZ-FR1Q3S3RA-39cfe428b7
Nice.
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Thu, 28 Nov 2019 02:19:58 +0000
Gerrit-HasComments: No
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14803 )
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
tserver: expose the number of round trips for a scanner
Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Reviewed-on: http://gerrit.cloudera.org:8080/14803
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tserver/tserver_path_handlers.cc
M www/scans.mustache
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 4
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14803 )
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14803/2/src/kudu/tserver/tserver_path_handlers.cc
File src/kudu/tserver/tserver_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/14803/2/src/kudu/tserver/tserver_path_handlers.cc@546
PS2, Line 546: number_of_round_trip
Nit: num_round_trips
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:51:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14803
to look at the new patch set (#2).
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
tserver: expose the number of round trips for a scanner
Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
---
M src/kudu/tserver/tserver_path_handlers.cc
M www/scans.mustache
2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/14803/2
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "helifu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14803
to look at the new patch set (#3).
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
tserver: expose the number of round trips for a scanner
Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
---
M src/kudu/tserver/tserver_path_handlers.cc
M www/scans.mustache
2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/14803/3
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "helifu (Code Review)" <ge...@cloudera.org>.
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14803 )
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
Patch Set 3:
> Sorry, forgot to mention in my first review, but could you include
> a screenshot in the gerrit change (or, if permalinked, in the
> commit message) showing the new /scans page in action?
Sure.
https://slack-files.com/T0CPU21PZ-FR1Q3S3RA-39cfe428b7
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Thu, 28 Nov 2019 02:14:51 +0000
Gerrit-HasComments: No
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14803 )
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
Patch Set 3:
Sorry, forgot to mention in my first review, but could you include a screenshot in the gerrit change (or, if permalinked, in the commit message) showing the new /scans page in action?
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 3
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Thu, 28 Nov 2019 01:55:32 +0000
Gerrit-HasComments: No
[kudu-CR] tserver: expose the number of round trips for a scanner
Posted by "helifu (Code Review)" <ge...@cloudera.org>.
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/14803 )
Change subject: tserver: expose the number of round trips for a scanner
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14803/2/src/kudu/tserver/tserver_path_handlers.cc
File src/kudu/tserver/tserver_path_handlers.cc:
http://gerrit.cloudera.org:8080/#/c/14803/2/src/kudu/tserver/tserver_path_handlers.cc@546
PS2, Line 546: number_of_round_trip
> Nit: num_round_trips
Done
--
To view, visit http://gerrit.cloudera.org:8080/14803
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia596049c156be5f79e55ac7082488ba1ba462441
Gerrit-Change-Number: 14803
Gerrit-PatchSet: 2
Gerrit-Owner: helifu <hz...@corp.netease.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: helifu <hz...@corp.netease.com>
Gerrit-Comment-Date: Thu, 28 Nov 2019 01:32:10 +0000
Gerrit-HasComments: Yes