You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/01/24 01:26:21 UTC
[kudu-CR] revert test changes from KUDU-2236
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12264
to review the following change.
Change subject: revert test changes from KUDU-2236
......................................................................
revert test changes from KUDU-2236
A couple of changes (d78b2727d1246069b2006ee652c3ff9a2005601c,
I7aafdc0eca00e743048ecc099dcb3241ce7ac8ad) for KUDU-2236 went in to make
testCloseShortlyAfterOpen less flaky, but failed to actually fix the
underlying logging regression.
Commit ead756844ce9ada904fcc3666df25692f63e76b8 fixed the regression, so
this patch restores the test to its former coverage. I looped the test
and it passed 200/200 runs, compared to the failure rate of 20-50%
reported in the Jira.
The above commit added a similar test, but given the tests test
different things, I've left both in.
Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/12264/1
--
To view, visit http://gerrit.cloudera.org:8080/12264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
Gerrit-Change-Number: 12264
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] revert test changes from KUDU-2236
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12264
to look at the new patch set (#2).
Change subject: revert test changes from KUDU-2236
......................................................................
revert test changes from KUDU-2236
A couple of changes (d78b2727d1246069b2006ee652c3ff9a2005601c,
a89c8f39544337c6ff36cdd28edec4fadac8427c) for KUDU-2236 went in to make
testCloseShortlyAfterOpen less flaky, but failed to actually fix the
underlying logging regression.
Commit ead756844ce9ada904fcc3666df25692f63e76b8 fixed the regression, so
this patch restores the test to its former coverage. I looped the test
and it passed 200/200 runs, compared to the failure rate of 20-50%
reported in the Jira.
The above commit added a similar test, but given the tests test
different things, I've left both in.
Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/12264/2
--
To view, visit http://gerrit.cloudera.org:8080/12264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
Gerrit-Change-Number: 12264
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] revert test changes from KUDU-2236
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12264 )
Change subject: revert test changes from KUDU-2236
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
Gerrit-Change-Number: 12264
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Jan 2019 01:35:52 +0000
Gerrit-HasComments: No
[kudu-CR] revert test changes from KUDU-2236
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12264 )
Change subject: revert test changes from KUDU-2236
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12264/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12264/1//COMMIT_MSG@10
PS1, Line 10: I7aafdc0eca00e743048ecc099dcb3241ce7ac8ad
This refers to a gerrit Change-Id; do you have a commit hash for it?
--
To view, visit http://gerrit.cloudera.org:8080/12264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
Gerrit-Change-Number: 12264
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Jan 2019 01:32:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] revert test changes from KUDU-2236
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12264 )
Change subject: revert test changes from KUDU-2236
......................................................................
revert test changes from KUDU-2236
A couple of changes (d78b2727d1246069b2006ee652c3ff9a2005601c,
a89c8f39544337c6ff36cdd28edec4fadac8427c) for KUDU-2236 went in to make
testCloseShortlyAfterOpen less flaky, but failed to actually fix the
underlying logging regression.
Commit ead756844ce9ada904fcc3666df25692f63e76b8 fixed the regression, so
this patch restores the test to its former coverage. I looped the test
and it passed 200/200 runs, compared to the failure rate of 20-50%
reported in the Jira.
The above commit added a similar test, but given the tests test
different things, I've left both in.
Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
Reviewed-on: http://gerrit.cloudera.org:8080/12264
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
Gerrit-Change-Number: 12264
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] revert test changes from KUDU-2236
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12264 )
Change subject: revert test changes from KUDU-2236
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12264/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12264/1//COMMIT_MSG@10
PS1, Line 10: a89c8f39544337c6ff36cdd28edec4fadac8427c)
> This refers to a gerrit Change-Id; do you have a commit hash for it?
Oops, done
--
To view, visit http://gerrit.cloudera.org:8080/12264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia93a454b06a40738152cc000d55caa197b64d461
Gerrit-Change-Number: 12264
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 24 Jan 2019 01:34:06 +0000
Gerrit-HasComments: Yes