[GitHub] [hbase] saintstack commented on a change in pull request #1116: HBASE-23783: Address tests writing and reading SSL/Security files in …

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #1116: HBASE-23783: Address tests writing and reading SSL/Security files in …
URL: https://github.com/apache/hbase/pull/1116#discussion_r374273924
 
 

 ##########
 File path: hbase-http/src/test/java/org/apache/hadoop/hbase/http/TestSSLHttpServer.java
 ##########
 @@ -51,62 +52,65 @@
 
   @ClassRule
   public static final HBaseClassTestRule CLASS_RULE =
-      HBaseClassTestRule.forClass(TestSSLHttpServer.class);
+    HBaseClassTestRule.forClass(TestSSLHttpServer.class);
 
   private static final String BASEDIR = System.getProperty("test.build.dir",
-      "target/test-dir") + "/" + TestSSLHttpServer.class.getSimpleName();
+    "target/test-dir") + "/" + TestSSLHttpServer.class.getSimpleName();
 
   private static final Logger LOG = LoggerFactory.getLogger(TestSSLHttpServer.class);
   private static Configuration conf;
   private static HttpServer server;
   private static URL baseUrl;
-  private static String keystoresDir;
+  private static File keystoresDir;
   private static String sslConfDir;
   private static SSLFactory clientSslFactory;
+  private static HBaseCommonTestingUtility htu;
 
 Review comment:
   Statics. normally capitalized as in HTU rather than htu.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services