[jira] [Comment Edited] (YETUS-660) checkstyle should report when it fails to execute

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584874#comment-16584874 ] 

Allen Wittenauer edited comment on YETUS-660 at 8/18/18 7:01 PM:
-----------------------------------------------------------------

-00:
* This patch removes the optimization came with the original maven install support as part of YETUS-144.  Given how jars may contain resources used by other tests, I believe there's no way for us to ignore it when it comes time to do a patch because we have no guaranteed way to know whether it is safe.  So now, if maven install was requested by a plugin, maven.sh will always do it.  (This problem was usually hidden because javac was triggered.)  This should take care of the problem with something like test-patch \-\-plugins=maven,checkstyle is given on the command line.
* Fixes up the test for when the ant/mvn/etc checkstyle command actually fails by keeping track of the exit code of the command, not the sed/grep pipeline.




was (Author: aw):
-00:
* This patch removes the optimization came with the original maven install support as part of YETUS-144.  Given how jars may contain resources used by other tests, I believe there's no way for us to ignore it when it comes time to do a patch because we have no guaranteed way to know whether it is safe.  So now, if maven install was requested by a plugin, maven.sh will always do it.  (This problem was usually hidden because javac was triggered.)
* Fixes up the test for when the ant/mvn/etc checkstyle command actually fails by keeping track of the exit code of the command, not the sed/grep pipeline.



> checkstyle should report when it fails to execute
> -------------------------------------------------
>
>                 Key: YETUS-660
>                 URL: https://issues.apache.org/jira/browse/YETUS-660
>             Project: Yetus
>          Issue Type: Bug
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Major
>             Fix For: 0.8.0
>
>         Attachments: YETUS-660.00.patch
>
>
> As shown in HDDS-119/HADOOP-15675, the checkstyle plug-in fails to determine if it didn't actually run. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)